Enhancement: Supports adding third-party dependencies from git repo with the version field

[Manoramsharma]

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

• N
• Y

fix : #266

2. What is the scope of this PR (e.g. component or file name):

pkg/client/client.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Other

I simply changed the logic of AddDepToPkg function to handle version field at the time of adding the dependencies to the pkg.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

• N
• Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

• Unit test
• Integration test
• Benchmark (add benchmark stats below)
• Manual test (add detailed scripts or steps below)
• Other

I directly modified the test_data for testing the unit tests. No need to make any other changes in unit test.

[Manoramsharma]

Hi @Peefy I was getting conflicts in the PR so here I have opened another one. But I still see the unit tests failing which are passing in my local see :

cc: @zong-zhe

[zong-zhe]

This is probably the main reason for your test failure, and it is also where the PR is not yet complete, currently full_name is used to generate the path of the local dependency. So full_name should be <name>_<git_tag>, <name>_<git_commit> or <name>_<git_branch>, Instead of <name>_<version>, the problem was caused by the old local dependency file storage structure, and finish #384 work was more helpful in solving the problem.

I suggest stopping this PR for a while to concentrate on #384

[Manoramsharma]

// GenDepFullName will generate the full name of a dependency by its name and version
// based on the '<package_name>_<package_tag>' format.
func (dep *Dependency) GenDepFullName() string {
    dep.FullName = fmt.Sprintf(PKG_NAME_PATTERN, dep.Name, dep.Version)
    return dep.FullName
}

Can this issue be resolved by changing the function mentioned above?

[zong-zhe]

Changes to this method may affect other features at this stage, resulting in more test failures and more work. And this part of the work will be meaningless after #384 done. Therefore, we can try to stop this PR temporarily. Finish this PR after you finish #384

[Manoramsharma]

I got your point now @zong-zhe

[Peefy]

The CI failed. cc @Manoramsharma

[Manoramsharma]

The CI failed. cc @Manoramsharma

The CI failed. cc @Manoramsharma

@zong-zhe told me to stop this PR until the #384 will be completed.

[Peefy]

The CI failed. cc @Manoramsharma

The CI failed. cc @Manoramsharma

@zong-zhe told me to stop this PR until the #384 will be completed.

I see. Thank you!