-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added checker module to validate kpm three-party dependencies #470
Conversation
e4e68bf
to
45a1065
Compare
cc: @zong-zhe |
Hi @NishantBansal2003 😄 You need to add more test cases to |
Pull Request Test Coverage Report for Build 10601682765Details
💛 - Coveralls |
Do you mean I need to add unit tests for the existing functions of the |
45a1065
to
7cb6655
Compare
Signed-off-by: Nishant Bansal <[email protected]>
7cb6655
to
8f64bb0
Compare
I have added unit tests. Please take a look. |
Hey @zong-zhe, regarding the implementation of |
Hi @NishantBansal2003 😄 You can continue to add internal implementations to this structure to support its ability to fetch the sum of dependencies. Line 62 in 107ee87
|
Sure working on it... |
Hey @zong-zhe, could you elaborate on this a bit more so I can research it in the meantime and propose a solution? Also, will there be any meetings scheduled in the future regarding the project? |
Hi @NishantBansal2003 😄
Line 222 in 107ee87
You need to transfer the unfinished work above to |
Hi @zong-zhe, |
Hi @NishantBansal2003 😄 Yes, this is the right direction, and the kpm project currently supports this, you do not need to do any other work, just run this script to get a local OCI Registry at |
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re #394
2. What is the scope of this PR (e.g. component or file name):
kcl-lang/kpm/pkg/checker
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This PR contains an isolated implementation of the checker module to validate KPM third-party dependencies. The changes have not yet been integrated with KPM third-party dependencies; integration will be done in the future once the checker module design is finalised. The PR includes:
IdentChecker
, which validates the dependency names inkclPkg
.VersionChecker
, which validates the dependency versions inkclPkg
.SumChecker
, which validates the dependency checksums inkclPkg
.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
There are some breaking changes: calling the
SumChecker
function will not work properly as the implementation ofgetTrustedSum
is incomplete and requires further discussion and design before completion. Once finalized, theSumChecker
can be called without causing any breaking issues.5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
Currently, unit tests for the checker module design have not been completed. These will be completed in the future upon further discussion and completion of this PR.
To verify the changes in the pkg/checker/ directory run the following commands: