Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a bug when check cyclic dependeny #483

Merged
merged 2 commits into from
Sep 14, 2024
Merged

fix: fix a bug when check cyclic dependeny #483

merged 2 commits into from
Sep 14, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Sep 14, 2024
@zong-zhe zong-zhe requested a review from Peefy September 14, 2024 09:25
@zong-zhe zong-zhe self-assigned this Sep 14, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zongz <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10861351592

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 41.945%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/client.go 4 7 57.14%
Totals Coverage Status
Change from base Build 10845006368: 0.009%
Covered Lines: 3450
Relevant Lines: 8225

💛 - Coveralls

@Peefy Peefy merged commit dc97867 into main Sep 14, 2024
6 checks passed
@Peefy Peefy deleted the fix-circular-dep branch September 14, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants