Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make vendor supports mvs #495

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Oct 9, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #478

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Oct 9, 2024
@zong-zhe zong-zhe requested a review from Peefy October 9, 2024 07:25
@zong-zhe zong-zhe self-assigned this Oct 9, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But windows CI failed.

@coveralls
Copy link

coveralls commented Oct 14, 2024

Pull Request Test Coverage Report for Build 11322137938

Details

  • 143 of 227 (63.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 41.924%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/client.go 7 9 77.78%
pkg/client/vendor.go 136 218 62.39%
Files with Coverage Reduction New Missed Lines %
pkg/client/client.go 1 56.86%
Totals Coverage Status
Change from base Build 11320601827: 0.4%
Covered Lines: 3600
Relevant Lines: 8587

💛 - Coveralls

Signed-off-by: zongzhe <[email protected]>
Signed-off-by: zongzhe <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 3875e75 into kcl-lang:main Oct 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants