Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Grammer #17

Merged
merged 2 commits into from
May 24, 2024
Merged

Adding Grammer #17

merged 2 commits into from
May 24, 2024

Conversation

Daksh-10
Copy link
Contributor

@Daksh-10 Daksh-10 commented May 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

#8

2. What is the scope of this PR (e.g. component or file name):

./grammar.js

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

I will be adding more syntax changes related to 'expressions' in KCL. In this PR, I improved assignment statement and syntax for '?' operator.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy
Copy link
Contributor

Peefy commented May 24, 2024

Hello.

Please not use the fix message in the PR description and it will lead to the PR be closed.

Please fix CI.

@Daksh-10
Copy link
Contributor Author

Hey @Peefy , there are lots of error tokens which gives a lot of ways to improve the grammar.js ( also as @Vishalk91-4 mentioned), I will also try to remove those error tokens :)

Signed-off-by: Daksh <[email protected]>
@Peefy Peefy merged commit ee8b294 into kcl-lang:main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants