Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'Schema' and 'Expression' Grammar #18

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

Daksh-10
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

#8

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Daksh-10 Daksh-10 changed the title Adding Grammar Adding Schema Grammar May 25, 2024
@Daksh-10 Daksh-10 changed the title Adding Schema Grammar Adding 'Schema' and 'Expression' Grammar May 25, 2024
src/tree_sitter/parser.h Show resolved Hide resolved
test/corpus/schema.txt Outdated Show resolved Hide resolved
test/corpus/schema.txt Outdated Show resolved Hide resolved
test/corpus/schema.txt Outdated Show resolved Hide resolved
test/corpus/schema.txt Outdated Show resolved Hide resolved
@Daksh-10 Daksh-10 marked this pull request as ready for review June 1, 2024 10:17
@Daksh-10
Copy link
Contributor Author

Daksh-10 commented Jun 1, 2024

With this PR, I have corrected the expression and schema test cases. Now only the 'type.txt' file is left for correction.

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1e74043 into kcl-lang:main Jun 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants