Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ERROR codes present in test files #19

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

Vishalk91-4
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • grammar.js
  • expr.txt
  • schema.txt
  • type.txt

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Vishalk91-4
Copy link
Contributor Author

@Peefy
I'm working on this PR for cleaning up the code of test files
There are still ERROR codes in 4 or so other test cases,
I'll solve them completely then open this PR up, if it's fine with you

@Vishalk91-4 Vishalk91-4 closed this Jun 1, 2024
@Vishalk91-4 Vishalk91-4 reopened this Jun 1, 2024
@Vishalk91-4 Vishalk91-4 marked this pull request as ready for review June 1, 2024 15:10
@Vishalk91-4
Copy link
Contributor Author

@Peefy,
I saw some of the ERROR codes already being implemented from the previous PR merged
So, I have fixed the only one remaining
Union Type

@Peefy Peefy merged commit c4dd575 into kcl-lang:main Jun 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants