Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update prow jobs, PR template, OWNERS and golangci-lint #89

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

embik
Copy link
Member

@embik embik commented Jan 24, 2024

Summary

This updates the prow jobs to Go 1.20.13 (plus golangci-lint for compatibility reasons), the PR template to include release notes and the OWNERS file to align with the project maintainers.

Couple of code changes to make the new linter configuration happy.

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2024
Signed-off-by: Marvin Beckers <[email protected]>
@embik embik changed the title 🌱 Update prow jobs, PR template and OWNERS 🌱 Update prow jobs, PR template, OWNERS and golangci-lint Jan 25, 2024
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2024
@embik embik self-assigned this Jan 25, 2024
@xrstf
Copy link

xrstf commented Mar 15, 2024

@sttts ping :)

I would like to resume work on this repo, as the controller-tools version we use here panics in Go 1.22 and needs an update.

@sttts
Copy link
Member

sttts commented Mar 21, 2024

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 80dc7236dd80034b64a35846c6a93e14cfd49c7e

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@kcp-ci-bot kcp-ci-bot merged commit 036a9bf into kcp-dev:main Mar 21, 2024
10 checks passed
@embik embik deleted the prow-owners-update branch March 21, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants