Skip to content

Commit

Permalink
pkg/server/options: add a TODO removal notice for admissionregistrati…
Browse files Browse the repository at this point in the history
…on.k8s.io/v1alpha1 override
  • Loading branch information
gman0 committed Feb 14, 2025
1 parent 290ff40 commit 9fbd890
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/server/options/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ func NewOptions(rootDir string) *Options {
// turn on the watch cache
o.GenericControlPlane.Etcd.EnableWatchCache = true

// TODO(gman0): remove this admissionregistration.k8s.io/v1alpha1 override once
// we reach Kubernetes v1.33. VAP will be removed from that API version then:
// https://github.com/kubernetes/kubernetes/pull/129207
// ValidatingAdmissionPolicy is GA, in admissionregistration.k8s.io/v1.
//
// Turn on admissionregistration for validating admission policy
if err := o.GenericControlPlane.APIEnablement.RuntimeConfig.Set("admissionregistration.k8s.io/v1alpha1=true"); err != nil {
panic(fmt.Errorf("error setting APIEnablement: %w", err))
Expand Down

0 comments on commit 9fbd890

Please sign in to comment.