Release 2.13.0 #593

wozniakjan · 2024-01-19T09:17:27Z

Preparation for the KEDA release 2.13.0

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Commits are signed with Developer Certificate of Origin (DCO - learn more)
README is updated with new configuration values (if applicable) learn more

1) CRD update - resolved in #593 (comment), `949b54f`

old question

1) CRD update - `2d22f00`

I did following procedure

# template CRDs for the latest release
kustomize build https://github.com/kedacore/keda/config/crd?ref=v2.13.0 > all.yaml

# split the templated file
yq -s '"crd-" + .spec.names.plural + ".yaml"' all.yaml

# move the split files to the correct location
mv crd-*.yaml ./keda/templates/crds/

and then copied back the helm templating manually to those CRDs but there seems to be a good amount of drift so I am sceptical of my process ...

2) removing deprecated webhook enable flag - `8e863fa`

the notes mentioned to remove it, just wanted to confirm this is the right time and place :)

tomkerkhove · 2024-01-19T10:02:25Z

I am not entirely sure about these two commits, ptal @kedacore/keda-core-contributors

1) CRD update - 2d22f00

I did following procedure
# template CRDs for the latest release
kustomize build https://github.com/kedacore/keda/config/crd?ref=v2.13.0 > all.yaml

# split the templated file
yq -s '"crd-" + .spec.names.plural + ".yaml"' all.yaml

# move the split files to the correct location
mv crd-*.yaml ./keda/templates/crds/
and then copied back the helm templating manually to those CRDs but there seems to be a good amount of drift so I am sceptical of my process ...

I honestly just copy the artifacts from KEDA's release and past them in the files, I do not use Kustomize for it

tomkerkhove · 2024-01-19T10:02:37Z

Mind adding the change from #558 in this PR please?

tomkerkhove · 2024-01-19T10:04:42Z

2) removing deprecated webhook enable flag - 8e863fa

the notes mentioned to remove it, just wanted to confirm this is the right time and place :)

@kedacore/keda-maintainers I'm not sure if we should do hard delete, or if we should change the default to true? I personally prefer the latter as people can still turn it off if they want, but recall we may have taken a dependency on it in 2.13

wozniakjan · 2024-01-19T10:08:22Z

Mind adding the change from #558 in this PR please?

I'm on it, thanks for reminding :)

@kedacore/keda-maintainers I'm not sure if we should do hard delete, or if we should change the default to true? I personally prefer the latter as people can still turn it off if they want, but recall we may have taken a dependency on it in 2.13

I would be in favour of keeping it and given the default is already true, I can just easily change the deprecation/removal note to mention 2.13 instead?

maybe @zroubalik or @JorTurFer have an opinion?

wozniakjan · 2024-01-19T10:32:35Z

I honestly just copy the artifacts from KEDA's release and past them in the files, I do not use Kustomize for it

@tomkerkhove, I investigated the diff a bit closer and the culprit is the yq I used to auto-split the crds yaml, lot a whitespace changes and line breaks in a different location, I will replace my attempt for automation with manual labour to reduce the diff :)

keda/values.yaml

tomkerkhove · 2024-01-19T11:13:28Z

I only see changes for trigger authentication, just to verify - The other CRDs did not change?

JorTurFer · 2024-01-19T11:19:45Z

I only see changes for trigger authentication, just to verify - The other CRDs did not change?

I don't think so, but let me double-check

JorTurFer · 2024-01-19T11:28:23Z

Sorry for the noise, could we include this PR as part of the release? #591

tomkerkhove · 2024-01-19T11:30:05Z

Merged, all we need to do is sync and re-package

wozniakjan · 2024-01-19T11:30:46Z

Merged, all we need to do is sync and re-package

I'm on it :)

Signed-off-by: Jan Wozniak <[email protected]>

$ helm package keda --destination docs Signed-off-by: Jan Wozniak <[email protected]>

$ helm repo index docs --url https://kedacore.github.io/charts Signed-off-by: Jan Wozniak <[email protected]>

wozniakjan · 2024-01-19T11:34:17Z

I don't think so, but let me double-check

I double checked, looks like only TA and CTA changed + CloudEvent CRDs got added as a new one in #572. These are the only diffs regarding CRDs I observed.

Also sync and re-package is now pushed.

tomkerkhove · 2024-01-19T11:42:50Z

@wozniakjan Did you verify that https://github.com/kedacore/charts/blob/main/keda/templates/crds/crd-cloudeventsources.yaml does not need any changes?

JorTurFer · 2024-01-19T11:44:03Z

@wozniakjan Did you verify that main/keda/templates/crds/crd-cloudeventsources.yaml does not need any changes?

I did it

…uing KEDA TLS certificates (#530) * feat(keda): ✨ Allow providing own cert-manager issuer in TLS certificate Signed-off-by: Dmytro Kovalenko <[email protected]> * docs(keda): 📝 Generate Helm docs Signed-off-by: Dmytro Kovalenko <[email protected]> * fix(keda): 🐛 Inject CA from cert-manager Certificate when providing own Issuer Signed-off-by: Dmytro Kovalenko <[email protected]> * refactor(keda): ♻️ Refactor values format Signed-off-by: Dmytro Kovalenko <[email protected]> * revert(keda): ⏪ Revert unnecessary auto-formatting Signed-off-by: Dmytro Kovalenko <[email protected]> * chore: Improve the CI on PRs to be more efficient (#540) Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * fix(http-add-on): Refactor the chart for next version (#523) Signed-off-by: Dmytro Kovalenko <[email protected]> * feat(add-on): Supporting streamInterval configuration (#541) Signed-off-by: Dmytro Kovalenko <[email protected]> * chore(add-on): Ship Release 0.6.0 (#543) Signed-off-by: Dmytro Kovalenko <[email protected]> * chore: update versions in README.md (#546) Signed-off-by: Dmytro Kovalenko <[email protected]> * feat: update crd to allow vault secret to handle write operation (#548) Signed-off-by: Loïs Postula <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Fix the svc name of webhook to avoid breaking istio (#551) Signed-off-by: Dmytro Kovalenko <[email protected]> * Show only logs with a severity level of ERROR or higher in the stderr (#506) Signed-off-by: Adarsh-verma-14 <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Support profiling for keda components (#549) Signed-off-by: yuval weber <[email protected]> Signed-off-by: unknown <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Fix TriggerAuthentication - added configuration for validation webhook (#553) Signed-off-by: Dmytro Kovalenko <[email protected]> * fix: Declare missing port in KEDA operator (#552) Signed-off-by: Dmytro Kovalenko <[email protected]> * Allow image registry override for all keda components (#557) Signed-off-by: Dmytro Kovalenko <[email protected]> * docs: Clarify that contributors do not have to ship Helm chart (#573) Signed-off-by: Dmytro Kovalenko <[email protected]> * add disable-compression arg for both operator and metrics-server (#554) Signed-off-by: Adarsh-verma-14 <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * feat: Introduce CloudEventSources CRD and adding ClusterName parameter (#572) * Add CloudEventSources Crd and ClustetName Parameter Signed-off-by: SpiritZhou <[email protected]> * Update Signed-off-by: SpiritZhou <[email protected]> * Update Signed-off-by: SpiritZhou <[email protected]> * Update keda/values.yaml Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: SpiritZhou <[email protected]> * Fix Signed-off-by: SpiritZhou <[email protected]> * Update Signed-off-by: SpiritZhou <[email protected]> * Revert unnecessary update Signed-off-by: SpiritZhou <[email protected]> --------- Signed-off-by: SpiritZhou <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * store 2.12.1 package at `main` (#577) Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * fix: restore http-add-on chart 0.6.0 indexing (#579) Signed-off-by: Dmytro Kovalenko <[email protected]> * fix(add-on): Use 'main' tag for KEDA installation during CI (#582) Signed-off-by: Dmytro Kovalenko <[email protected]> * set securityContext for http-add-on chart (#561) Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Fix http-add-on operator resources (#567) Signed-off-by: Dmytro Kovalenko <[email protected]> * Fix http-add-on verbosity configuration (#568) Signed-off-by: Dmytro Kovalenko <[email protected]> * chore: Adjust RBAC with code (#585) * chore: Adjust RBAC with code Signed-off-by: Jorge Turrado <[email protected]> * fix typo Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * fix: Don't recreate CA with 8 months until it expires (#586) Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * feat(ClusterRole): Add RBAC rule to allow access to `LimitRange` (#588) Signed-off-by: Dmytro Kovalenko <[email protected]> * remove not required insecureSkipTLSVerify (#564) Signed-off-by: Frank Kloeker <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Update templates/webhooks deployment (#590) Align deployment for extraVolumes and extraVolumesMount for fix problem Error: YAML parse error on keda/templates/webhooks/deployment.yaml: error converting YAML to JSON: yaml: line 96: did not find expected key Signed-off-by: ferndem <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Fix Prometheus metrics handling for the operator. (#555) The current state of the Helm chart is slightly confusing, because: - There's no easy way to really disable prometheus metrics -- `--enable-prometheus-metrics` defaults to true anthe current code either emits `--enable-prometheus-metrics=true` or nothing at all (making it `true` once again). - The `http` container port is actually a `metrics` port (by convention from .e.g. webhook), but is present regardless of whether Prometheus metrics are enabled or not. To make it less confusing, this PR proposes renaming it. Signed-off-by: Milan Plzik <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Fix Remove app.kubernetes.io/instance label in crd (#556) Signed-off-by: choisungwook <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Support crd-specific annotations (#584) * support crd-specific annotations Signed-off-by: Adam Walford <[email protected]> * update readme Signed-off-by: Adam Walford <[email protected]> * update docs using helm-docs Signed-off-by: Adam Walford <[email protected]> --------- Signed-off-by: Adam Walford <[email protected]> Co-authored-by: Adam Walford <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Add ciliumnetworkpolicies (#558) Signed-off-by: Dmytro Kovalenko <[email protected]> * Add tlsConfig for ServiceMonitor (#591) Co-authored-by: guicholeo <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * Release 2.13.0 (#593) Signed-off-by: Dmytro Kovalenko <[email protected]> * fix: Ship v2.13.1 with missing RoleBinding (#595) Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * chore(add-on): Apply HTTP Add-on changes on Helm chart (#598) Signed-off-by: Dmytro Kovalenko <[email protected]> * chore(add-on): Release v0.7.0 (#599) Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Dmytro Kovalenko <[email protected]> * refactor: Unify cert-manager annotations Signed-off-by: Dmytro Kovalenko <[email protected]> --------- Signed-off-by: Dmytro Kovalenko <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Loïs Postula <[email protected]> Signed-off-by: Adarsh-verma-14 <[email protected]> Signed-off-by: yuval weber <[email protected]> Signed-off-by: unknown <[email protected]> Signed-off-by: SpiritZhou <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Frank Kloeker <[email protected]> Signed-off-by: ferndem <[email protected]> Signed-off-by: Milan Plzik <[email protected]> Signed-off-by: choisungwook <[email protected]> Signed-off-by: Adam Walford <[email protected]> Co-authored-by: Dmytro Kovalenko <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Loïs Postula <[email protected]> Co-authored-by: Roy Gao <[email protected]> Co-authored-by: Adarsh Verma <[email protected]> Co-authored-by: yuval weber <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Co-authored-by: Radek Fojtik <[email protected]> Co-authored-by: Quentin Bisson <[email protected]> Co-authored-by: SpiritZhou <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Co-authored-by: Frank Kloeker <[email protected]> Co-authored-by: Andrew <[email protected]> Co-authored-by: Bhargav Ravuri <[email protected]> Co-authored-by: ferndem <[email protected]> Co-authored-by: Milan Plžík <[email protected]> Co-authored-by: choisungwook <[email protected]> Co-authored-by: Adam Walford <[email protected]> Co-authored-by: Adam Walford <[email protected]> Co-authored-by: guicholeo <[email protected]> Co-authored-by: Jan Wozniak <[email protected]>

wozniakjan force-pushed the release_2.13.0 branch from 3208066 to e06d213 Compare January 19, 2024 09:43

wozniakjan mentioned this pull request Jan 19, 2024

Release: 2.13.0 kedacore/keda#5275

Closed

25 tasks

wozniakjan marked this pull request as ready for review January 19, 2024 09:55

wozniakjan requested a review from a team as a code owner January 19, 2024 09:56

wozniakjan force-pushed the release_2.13.0 branch from e06d213 to 972c0ca Compare January 19, 2024 10:17

wozniakjan force-pushed the release_2.13.0 branch from 972c0ca to 7112110 Compare January 19, 2024 10:42

JorTurFer reviewed Jan 19, 2024

View reviewed changes

keda/values.yaml Outdated Show resolved Hide resolved

wozniakjan force-pushed the release_2.13.0 branch from 7112110 to c4e20df Compare January 19, 2024 11:03

JorTurFer approved these changes Jan 19, 2024

View reviewed changes

tomkerkhove approved these changes Jan 19, 2024

View reviewed changes

wozniakjan added 6 commits January 19, 2024 12:31

bump chart version to v 2.13.0

161b553

Signed-off-by: Jan Wozniak <[email protected]>

update chart notes with k8s 1.27 support

6b53a73

Signed-off-by: Jan Wozniak <[email protected]>

bump keda to 2.13.0 in README

92db184

Signed-off-by: Jan Wozniak <[email protected]>

update CRDs to v2.13.0

336c7ea

Signed-off-by: Jan Wozniak <[email protected]>

create new package

e69635f

$ helm package keda --destination docs Signed-off-by: Jan Wozniak <[email protected]>

update helm index

74acc50

$ helm repo index docs --url https://kedacore.github.io/charts Signed-off-by: Jan Wozniak <[email protected]>

wozniakjan force-pushed the release_2.13.0 branch from c4e20df to 74acc50 Compare January 19, 2024 11:32

tomkerkhove merged commit 0520e8f into kedacore:main Jan 19, 2024
37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.13.0 #593

Release 2.13.0 #593

wozniakjan commented Jan 19, 2024

wozniakjan commented Jan 19, 2024 •

edited

Loading

1) CRD update - `2d22f00`

tomkerkhove commented Jan 19, 2024

1) CRD update - 2d22f00

tomkerkhove commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

2) removing deprecated webhook enable flag - 8e863fa

wozniakjan commented Jan 19, 2024 •

edited

Loading

wozniakjan commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

wozniakjan commented Jan 19, 2024

wozniakjan commented Jan 19, 2024 •

edited

Loading

tomkerkhove commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

Release 2.13.0 #593

Release 2.13.0 #593

Conversation

wozniakjan commented Jan 19, 2024

Checklist

wozniakjan commented Jan 19, 2024 • edited Loading

1) CRD update - resolved in #593 (comment), 949b54f

1) CRD update - 2d22f00

2) removing deprecated webhook enable flag - 8e863fa

tomkerkhove commented Jan 19, 2024

1) CRD update - 2d22f00

tomkerkhove commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

2) removing deprecated webhook enable flag - 8e863fa

wozniakjan commented Jan 19, 2024 • edited Loading

wozniakjan commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

wozniakjan commented Jan 19, 2024

wozniakjan commented Jan 19, 2024 • edited Loading

tomkerkhove commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

wozniakjan commented Jan 19, 2024 •

edited

Loading

1) CRD update - resolved in #593 (comment), `949b54f`

1) CRD update - `2d22f00`

2) removing deprecated webhook enable flag - `8e863fa`

wozniakjan commented Jan 19, 2024 •

edited

Loading

wozniakjan commented Jan 19, 2024 •

edited

Loading