Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal Scaler Trigger documentation #1163

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Temporal Scaler Trigger documentation #1163

wants to merge 6 commits into from

Conversation

ross-p-smith
Copy link
Contributor

@ross-p-smith ross-p-smith commented Jun 21, 2023 •
edited
Loading

Added the required documentation for a Temporal scaler that is here: - https://github.com/ross-p-smith/keda.git

Checklist

@ross-p-smith ross-p-smith requested a review from a team as a code owner June 21, 2023 10:49
@netlify
Copy link

netlify bot commented Jun 21, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit f60337c
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/64930bedfb44650008fca1bf
😎 Deploy Preview https://deploy-preview-1163--keda.netlify.app/docs/2.11/scalers/github-runner
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@ross-p-smith
Added docs for Temporal
aa3a721 
Signed-off-by: ross-p-smith <[email protected]>
@ross-p-smith ross-p-smith mentioned this pull request Jun 21, 2023
Closed
7 tasks
tomkerkhove
tomkerkhove reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind aligning with https://github.com/kedacore/keda-docs#writing-documentation-for-a-scaler please?

content/docs/2.11/scalers/temporal-scaler.md Outdated Show resolved Hide resolved
tomkerkhove
tomkerkhove approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Waiting for feature to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ross-p-smith @tomkerkhove