Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: External Scalers docs explain correctly the parameters #1248

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

JorTurFer
Copy link
Member

Since KEDA v2.11, external scalers are wrong because docs say that new fields are got from trigger.metadata but they are recovered from trigger auth: kedacore/keda#4407

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@JorTurFer JorTurFer requested a review from a team as a code owner October 16, 2023 07:13
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit d92ba75
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/652ce29a7313400008faf648
😎 Deploy Preview https://deploy-preview-1248--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove tomkerkhove merged commit e2fef7d into kedacore:main Oct 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants