Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admission-webhooks.md - prevention rules updated #1254

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Admission-webhooks.md - prevention rules updated #1254

merged 1 commit into from
Oct 26, 2023

Conversation

radekfojtik
Copy link
Contributor

@radekfojtik radekfojtik commented Oct 26, 2023 •
edited
Loading

Releated to kedacore/keda#4670

Admission-webhooks.md - prevention rules updated

  • Added rule for unique trigger name

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@radekfojtik radekfojtik requested a review from a team as a code owner October 26, 2023 11:13
@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit dc16d4e
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/653a49ca14190e000883c7ef
😎 Deploy Preview https://deploy-preview-1254--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@radekfojtik
Copy link
Contributor Author

@zroubalik please take a look

@zroubalik
Copy link
Member

Good catch. Thanks!

@zroubalik zroubalik merged commit 7b1f63f into kedacore:main Oct 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radekfojtik @zroubalik