Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wingie enuygun group logo #1255

Merged
merged 4 commits into from
Oct 27, 2023
Merged

add wingie enuygun group logo #1255

merged 4 commits into from
Oct 27, 2023

Conversation

yasamdogan
Copy link
Contributor

@yasamdogan yasamdogan commented Oct 27, 2023 •
edited
Loading

Signed-off-by: Yasam Dogan [email protected]

@yasamdogan yasamdogan requested a review from a team as a code owner October 27, 2023 08:03
@netlify
Copy link

netlify bot commented Oct 27, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 982fdac
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/653b8656aab34f0008421ac5
😎 Deploy Preview https://deploy-preview-1255--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

zroubalik
zroubalik reviewed Oct 27, 2023
View reviewed changes
config.toml Outdated Show resolved Hide resolved
zroubalik
zroubalik approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome 🎉

@zroubalik
Copy link
Member

zroubalik commented Oct 27, 2023 •
edited
Loading

@yardenshoham please also fix DCO:
https://github.com/kedacore/keda-docs/pull/1255/checks?check_run_id=18112531793

https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

@yardenshoham
Copy link
Contributor

Autocomplete issue of a username starting with ya?

@zroubalik
Copy link
Member

Autocomplete issue of a username starting with ya?

Lol, yes, sorry :)

zroubalik
zroubalik requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasamdogan please also fix DCO:
https://github.com/kedacore/keda-docs/pull/1255/checks?check_run_id=18112531793

https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

yasamdogan
yasamdogan commented Oct 27, 2023
View reviewed changes
Copy link
Contributor Author

@yasamdogan yasamdogan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this problem
thanks for support

@zroubalik
Copy link
Member

@yasamdogan

In your local branch, run: git rebase HEAD~4 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin main

yasamdogan added 4 commits October 27, 2023 12:43
add wingie enuygun group logo
a82f36d 
Signed-off-by: yasamdogan <[email protected]>
sorted alphabetically
debc114 
Signed-off-by: yasamdogan <[email protected]>
fix DCO
786ebbf 
Signed-off-by: Yaşam Doğan <[email protected]>
Signed-off-by: yasamdogan <[email protected]>
space deleted
982fdac 
Signed-off-by: Yasam Dogan <[email protected]>
Signed-off-by: yasamdogan <[email protected]>
@zroubalik zroubalik merged commit c6ba5ba into kedacore:main Oct 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasamdogan @zroubalik @yardenshoham