Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(external-push): remove duplicate #1268

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

Nico385412
Copy link
Contributor

@Nico385412 Nico385412 commented Nov 30, 2023

Hello, i notice some duplicate documentation.
here's a PR to remove it

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Signed-off-by: Nicolas Hansse <[email protected]>
@Nico385412 Nico385412 requested a review from a team as a code owner November 30, 2023 07:59
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit f4c1255
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/656840e31d6db70008350ff2
😎 Deploy Preview https://deploy-preview-1268--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@Nico385412 Nico385412 changed the title fix: remove duplicate doc(external-push): remove duplicate Nov 30, 2023
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Could you update version v2.13 as well?

@Nico385412
Copy link
Contributor Author

Nice catch! Could you update version v2.13 as well?

Hello !
Looks like it's already fixed in v2.13 ^^"
https://github.com/kedacore/keda-docs/blob/main/content/docs/2.13/scalers/external-push.md#authentication-parameters

@JorTurFer
Copy link
Member

Lol, you are right!
Thanks for the fix ❤️

@JorTurFer JorTurFer merged commit acc0b2c into kedacore:main Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants