Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs on metric value needing to be greater than activation value #1295

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

DP19
Copy link
Contributor

@DP19 DP19 commented Jan 16, 2024

Related to kedacore/keda#5383. Updating the activation docs to make it more clear on the value needing to be greater than this value, not equal to

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#5383

@DP19 DP19 requested a review from a team as a code owner January 16, 2024 19:06
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 0822df0
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65aaa61b32e3af0008aef1a7
😎 Deploy Preview https://deploy-preview-1295--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! Could you update versions above 2.8 as well? We introduced the activation concept on v2.8 so adding this clarification on all the affected version would be nice

@DP19
Copy link
Contributor Author

DP19 commented Jan 19, 2024

Thanks for the clarification! Could you update versions above 2.8 as well? We introduced the activation concept on v2.8 so adding this clarification on all the affected version would be nice

@JorTurFer 👍🏻 - Also updated 2.14 since 2.13 was just released

@DP19 DP19 requested a review from JorTurFer January 19, 2024 16:41
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the improvement!

@JorTurFer JorTurFer merged commit bd1589b into kedacore:main Jan 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP PubSub activationValue not working correctly
2 participants