Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update docs to reflect changes in eventhub after the SDK migration #1313

Merged
merged 3 commits into from
Jul 31, 2024
Merged

chore: Update docs to reflect changes in eventhub after the SDK migration #1313

merged 3 commits into from
Jul 31, 2024

Conversation

JorTurFer
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@JorTurFer JorTurFer requested a review from a team as a code owner February 13, 2024 21:07
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit c918fc1
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66a0e6901797f80008fa2f47
😎 Deploy Preview https://deploy-preview-1313--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JorTurFer JorTurFer mentioned this pull request Feb 13, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

JorTurFer and others added 3 commits July 24, 2024 13:29
@JorTurFer
chore: Update docs to reflect changes in eventhub after the SDK migra…
29129f2 
…tion

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Add a note
4fedeba 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Update references
c918fc1 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

@tomkerkhove PTAL, I've addressed the comments and moved the change to the right version

@JorTurFer JorTurFer enabled auto-merge (squash) July 24, 2024 15:05
@JorTurFer JorTurFer merged commit 401b6ca into kedacore:main Jul 31, 2024
7 checks passed
@JorTurFer JorTurFer deleted the migrate-sdk branch July 31, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @zroubalik @tomkerkhove