Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct grammatical mistake in scaling-deployments.md #1315

Closed
wants to merge 1 commit into from

Conversation

piyush1104
Copy link

Fixes a small grammatical mistake in the Caching Metrics section of scaling deployments doc.

Fix a small grammatical mistake in the *Caching Metrics* section of scaling deployments doc. 

Signed-off-by: Piyush Bansal <[email protected]>
@piyush1104 piyush1104 requested a review from a team as a code owner February 14, 2024 13:23
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 565d096
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65ccbed8b091d30009b2957e
😎 Deploy Preview https://deploy-preview-1315--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush1104 good catch, thanks! Would you mind fixing this also for other versions?

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update v2.14 as well?

@JorTurFer
Copy link
Member

I'm going to merge this as part of my release PR, thanks for the contribution! ❤️

@JorTurFer JorTurFer closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants