Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scalers not shown on landing page #1314 #1316

Closed
wants to merge 1 commit into from

Conversation

maxiangelo
Copy link

Remove bugged feature that causes scaler cards to load incorrectly.

Fixes #1314

remove bugged feature

Signed-off-by:  Maximilian Bauer <[email protected]>

Signed-off-by: Max <[email protected]>
@maxiangelo maxiangelo requested a review from a team as a code owner February 14, 2024 14:43
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 870ea95
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65ccd18bd9f4c50008179d23
😎 Deploy Preview https://deploy-preview-1316--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove
Copy link
Member

This is going to break @thisisobate's recent change. @thisisobate care to help fix this issue please?

@thisisobate
Copy link
Contributor

@tomkerkhove Sure, will take a look at this and try to push a fix soon

@thisisobate
Copy link
Contributor

Here's a fix: #1319
@tomkerkhove @maxiangelo

@tomkerkhove
Copy link
Member

This was fixed by @thisisobate, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalers not shown on landing page
3 participants