Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dynatrace scaler docs #1360

Merged
merged 11 commits into from
Jul 30, 2024
Merged

Add Dynatrace scaler docs #1360

merged 11 commits into from
Jul 30, 2024

Conversation

cyrilico
Copy link
Contributor

Add documentation on how to use new Dynatrace scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#5685

@cyrilico
add docs
442d5d1 
Signed-off-by: cyrilico <[email protected]>
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 3616ccf
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66a7670169417d000801a62a
😎 Deploy Preview https://deploy-preview-1360--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cyrilico cyrilico mentioned this pull request Apr 12, 2024
Merged
6 tasks
@cyrilico
add to 2.13
4955d92 
Signed-off-by: cyrilico <[email protected]>
@cyrilico
remove 2.13
3189cb4 
Signed-off-by: cyrilico <[email protected]>
@cyrilico cyrilico marked this pull request as ready for review April 12, 2024 11:53
@cyrilico cyrilico requested a review from a team as a code owner April 12, 2024 11:53
@cyrilico

This comment was marked as outdated.

Sign in to view
tomkerkhove
tomkerkhove reviewed Apr 24, 2024
View reviewed changes
content/docs/2.14/scalers/dynatrace.md Outdated Show resolved Hide resolved
content/docs/2.14/scalers/dynatrace.md Outdated Show resolved Hide resolved
content/docs/2.14/scalers/dynatrace.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

Could you move the file from v2.14 to v2.15? This will be released as part of v2.15

@cyrilico
Copy link
Contributor Author

Moved @JorTurFer 👍 I'm not sure how to tackle the CI errors, they seem to be trying to look for a previous page version, which does not make sense in this context:

3:51:59 PM: docs/2.15/scalers/dynatrace/index.html
3:51:59 PM:   target does not exist --- docs/2.15/scalers/dynatrace/index.html --> /docs/2.14/scalers/dynatrace/
3:52:00 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
3:52:00 PM: ========================================================================
3:52:00 PM: ✘✘✘ failed in 1.338598592s
3:52:00 PM: 1 errors in 1371 documents
3:52:00 PM: make: *** [Makefile:17: check-links] Error 1

@JorTurFer
Copy link
Member

Yeah, I forgot to explain it, sorry
You need to include the link as excluded verification links here -> https://github.com/kedacore/keda-docs/blob/main/.htmltest.yml
Splunk scaler is an example about how to add it

JorTurFer
JorTurFer reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice! just 2 quick suggestions inline

content/docs/2.15/scalers/dynatrace.md Outdated Show resolved Hide resolved
content/docs/2.15/scalers/dynatrace.md Outdated Show resolved Hide resolved
cyrilico and others added 2 commits July 29, 2024 10:30
@cyrilico @JorTurFer
Update content/docs/2.15/scalers/dynatrace.md
4f6fe5a 
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: cyrilico <[email protected]>
@cyrilico
ignore non-existent 2.14 dynatrace link
014d7d2 
Signed-off-by: cyrilico <[email protected]>
@cyrilico cyrilico requested a review from JorTurFer July 29, 2024 09:34
JorTurFer
JorTurFer approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@JorTurFer JorTurFer merged commit c01eb79 into kedacore:main Jul 30, 2024
7 checks passed
@cyrilico cyrilico deleted the dynatrace_scaler_docs branch July 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyrilico @JorTurFer @zroubalik @tomkerkhove