remove metrics server leader election env vars #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JorTurFer
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Checking the code, those envs are still in use and they should be removed from the code before. This means that we should remove them only from v2.15 version and remove them from the code too -> https://github.com/kedacore/keda/blob/main/cmd/adapter/main.go#L89-L105
Could you update this PR and create another PR removing the code? I've reviewed the adapter and nothing is using the leader election API, so it's safe removing it
Signed-off-by: lanting.chiang <[email protected]>
7 tasks
JorTurFer
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation originally mentions the possibility to set leader election parameters through environment variables for the keda-metrics-server. However, it was confirmed in #1450 that the keda-metrics-server does not use leader election, and these parameters should not be there.
Checklist
Fixes #