Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Selenium Grid scaler #1468

Merged
merged 7 commits into from
Nov 3, 2024
Merged

Update for Selenium Grid scaler #1468

merged 7 commits into from
Nov 3, 2024

Conversation

VietND96
Copy link
Contributor

Provide a description of what has been changed

An update for kedacore/keda#6169 will come in the upcoming release v2.16.
@SeleniumHQ involve as long term maintainer for the scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@VietND96 VietND96 requested a review from a team as a code owner September 17, 2024 11:38
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 7ebfabb
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6727b843cc5d490008291e18
😎 Deploy Preview https://deploy-preview-1468--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VietND96 VietND96 changed the title Update for Selenium Grid scaler in release 2.16 Update for Selenium Grid scaler Sep 23, 2024
@VietND96
Copy link
Contributor Author

Updated this to be aligned with the decision in core changes.

@VietND96
Update for Selenium Grid scaler in release 2.16
ce18648 
@SeleniumHQ involve as maintainer

Signed-off-by: Viet Nguyen Duc <[email protected]>
JorTurFer
JorTurFer approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️
@zroubalik PTAL

VietND96 and others added 4 commits November 3, 2024 17:55
@VietND96 @JorTurFer
Update docs for selenium-grid-scaler
34c05fd 
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
@VietND96 @JorTurFer
Update for selenium-grid-scaler
6ec5ab2 
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
@VietND96
Merge branch 'main' into main
2fd939f
@VietND96
Update as standard
7ebfabb 
Signed-off-by: Viet Nguyen Duc <[email protected]>
@JorTurFer
Copy link
Member

Thanks a lot for your help and patience 🙇

@JorTurFer JorTurFer merged commit 5f6f155 into kedacore:main Nov 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VietND96 @JorTurFer @zroubalik