Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation for cpu/memory activation feature #1470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add documentation for cpu/memory activation feature #1470

wants to merge 1 commit into from

Conversation

kunwooy
Copy link

@kunwooy kunwooy commented Sep 18, 2024 •
edited
Loading

Add documentation for cpu/memory scaler activation feature.
Relates to #6174

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@kunwooy kunwooy requested a review from a team as a code owner September 18, 2024 12:21
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit c3049f1
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66eac5bf0cb8ac0008281425
😎 Deploy Preview https://deploy-preview-1470--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zroubalik
zroubalik reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we whould be more verbose here and explain that this is not a typical de/activation as it works in a combination with other scaler etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunwooy @zroubalik