Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: validating webhook policies to limit number of replicas #1471

Merged
merged 2 commits into from
Sep 23, 2024
Merged

docs: validating webhook policies to limit number of replicas #1471

merged 2 commits into from
Sep 23, 2024

Conversation

Tomer20
Copy link
Contributor

@Tomer20 Tomer20 commented Sep 20, 2024

Added examples of ValidatingAdmissionPolicy to fail/deny ScaledObjects based on maxReplicaCount.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@Tomer20 Tomer20 requested a review from a team as a code owner September 20, 2024 12:22
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit ee00cc1
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66ef9b6ad576c10008940cf4
😎 Deploy Preview https://deploy-preview-1471--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tomer20 Tomer20 mentioned this pull request Sep 20, 2024
Open
zroubalik
zroubalik reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you please also add similar change to version 2.16?

content/docs/2.15/operate/admission-webhooks.md Outdated Show resolved Hide resolved
@Tomer20
Copy link
Contributor Author

Tomer20 commented Sep 22, 2024 •
edited
Loading

Thanks!

Could you please also add similar change to version 2.16?

Thanks for the feedback @zroubalik. I added the docs for v2.16 as well.

zroubalik
zroubalik approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zroubalik zroubalik merged commit b463412 into kedacore:main Sep 23, 2024
7 checks passed
@Tomer20 Tomer20 deleted the docs/limit-replicas-validation branch September 25, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomer20 @zroubalik