Apply suggestions from code review

Signed-off-by: Jorge Turrado Ferrero <[email protected]>
kedacore · Jan 20, 2024 · 6485f67 · 6485f67
1 parent 9a2a86f
commit 6485f67
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -66,8 +66,7 @@ Here is an overview of all new **experimental** features:
 
 ### Fixes
 
-- **General**: TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX))
-- **AWS AMP Prometheus scaler**: Fix for missing awsRegion from metadata ([#5419](https://github.com/kedacore/keda/issues/5419))
+- **Prometheus Scaler**: Fix for missing AWS region from metadata ([#5419](https://github.com/kedacore/keda/issues/5419))
 
 ### Deprecations
 

diff --git a/pkg/scalers/aws/aws_sigv4.go b/pkg/scalers/aws/aws_sigv4.go
@@ -77,8 +77,6 @@ func parseAwsAMPMetadata(config *scalersconfig.ScalerConfig) (*awsConfigMetadata
 
 	if val, ok := config.TriggerMetadata["awsRegion"]; ok && val != "" {
 		meta.awsRegion = val
-	} else {
-		return nil, ErrAwsAMPNoAwsRegion
 	}
 
 	auth, err := GetAwsAuthorization(config.TriggerUniqueKey, config.PodIdentity, config.TriggerMetadata, config.AuthParams, config.ResolvedEnv)