Skip to content

Commit

Permalink
update conditional logic for is active to be greater than or equal to…
Browse files Browse the repository at this point in the history
… activationValue

Signed-off-by: David Pait <[email protected]>
  • Loading branch information
DP19 committed Jan 16, 2024
1 parent 56385f1 commit b13dc65
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ Here is an overview of all new **experimental** features:
- **Azure Event Hub Scaler**: Improve unprocessedEventThreshold calculation ([#4250](https://github.com/kedacore/keda/issues/4250))
- **Azure Pipelines**: No more HTTP 400 errors produced by poolName with spaces ([#5107](https://github.com/kedacore/keda/issues/5107))
- **GCP pubsub scaler**: Added `project_id` to filter for metrics queries ([#5256](https://github.com/kedacore/keda/issues/5256))
- **GCP pubsub scaler**: Fix scaler is Active logic to include activationValue instead of being greater than ([#5383](https://github.com/kedacore/keda/issues/5383))
- **GCP pubsub scaler**: Missing use of default value of `value` added ([#5093](https://github.com/kedacore/keda/issues/5093))
- **NATS JetSteam Scaler**: Raise an error if leader not found ([#5358](https://github.com/kedacore/keda/pull/5358))
- **Pulsar scaler**: Fix panic when auth is not used ([#5271](https://github.com/kedacore/keda/issues/5271))
Expand Down
2 changes: 1 addition & 1 deletion pkg/scalers/gcp_pubsub_scaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func (s *pubsubScaler) GetMetricsAndActivity(ctx context.Context, metricName str

metric := GenerateMetricInMili(metricName, value)

return []external_metrics.ExternalMetricValue{metric}, value > s.metadata.activationValue, nil
return []external_metrics.ExternalMetricValue{metric}, value >= s.metadata.activationValue, nil
}

func (s *pubsubScaler) setStackdriverClient(ctx context.Context) error {
Expand Down

0 comments on commit b13dc65

Please sign in to comment.