Apply suggestions from code review

Signed-off-by: Jorge Turrado Ferrero <[email protected]>
kedacore · Jan 17, 2024 · c3bb6ab · c3bb6ab
1 parent f73c7aa
commit c3bb6ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/tests/scalers/aws/aws_managed_prometheus/aws_managed_prometheus_test.go b/tests/scalers/aws/aws_managed_prometheus/aws_managed_prometheus_test.go
@@ -138,7 +138,8 @@ func TestScaler(t *testing.T) {
 	t.Log("--- setting up ---")
 
 	ampClient := createAMPClient()
-	workspaceOutput, _ := ampClient.CreateWorkspace(context.Background(), nil)
+	workspaceOutput, err := ampClient.CreateWorkspace(context.Background(), nil)
+	assert.Error(t, err, "aws prometheus workspace creation has failed")
 	workspaceID = *workspaceOutput.WorkspaceId
 
 	kc := GetKubernetesClient(t)
@@ -156,7 +157,7 @@ func TestScaler(t *testing.T) {
 		WorkspaceId: &workspaceID,
 	}
 	input := &deleteWSInput
-	_, err := ampClient.DeleteWorkspace(context.Background(), input)
+	_, err = ampClient.DeleteWorkspace(context.Background(), input)
 	if err != nil {
 		t.Log("Unable to delete AMP workspace", err)
 	}

diff --git a/...alers/aws/aws_managed_prometheus_pod_identity/aws_managed_prometheus_pod_identity_test.go b/...alers/aws/aws_managed_prometheus_pod_identity/aws_managed_prometheus_pod_identity_test.go
@@ -123,7 +123,8 @@ func TestScaler(t *testing.T) {
 	t.Log("--- setting up ---")
 
 	ampClient := createAMPClient()
-	workspaceOutput, _ := ampClient.CreateWorkspace(context.Background(), nil)
+	workspaceOutput, err := ampClient.CreateWorkspace(context.Background(), nil)
+	assert.Error(t, err, "aws prometheus workspace creation has failed")
 	workspaceID = *workspaceOutput.WorkspaceId
 
 	kc := GetKubernetesClient(t)
@@ -141,7 +142,7 @@ func TestScaler(t *testing.T) {
 		WorkspaceId: &workspaceID,
 	}
 	input := &deleteWSInput
-	_, err := ampClient.DeleteWorkspace(context.Background(), input)
+	_, err = ampClient.DeleteWorkspace(context.Background(), input)
 	if err != nil {
 		t.Log("Unable to delete AMP workspace", err)
 	}