apply feedback

Signed-off-by: Jorge Turrado <[email protected]>
kedacore · Nov 4, 2024 · c6811c9 · c6811c9
1 parent a072763
commit c6811c9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/scaling/cache/scalers_cache.go b/pkg/scaling/cache/scalers_cache.go
@@ -89,10 +89,10 @@ func (c *ScalersCache) GetPushScalers() []scalers.PushScaler {
 
 // Close closes all scalers in the cache
 func (c *ScalersCache) Close(ctx context.Context) {
-	c.mutex.RLock()
-	defer c.mutex.RUnlock()
+	c.mutex.Lock()
 	scalers := c.Scalers
 	c.Scalers = nil
+	c.mutex.Unlock()
 	for _, s := range scalers {
 		err := s.Scaler.Close(ctx)
 		if err != nil {