Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the implementation of OpenTelemetry integration #5116

Merged
merged 9 commits into from
Nov 1, 2023

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Oct 23, 2023

Improve the implementation of OpenTelemetry integration to reduce the callback register times

Checklist

Relates to (#5101)

Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou SpiritZhou requested a review from a team as a code owner October 23, 2023 08:05
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests for this change please?

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: SpiritZhou <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Oct 29, 2023

/run-e2e sequential
Update: You can check the progress here

@zroubalik zroubalik merged commit faf8c9a into kedacore:main Nov 1, 2023
17 of 18 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: anton.lysina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants