Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix jetstream flaky test #5372

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 13, 2024

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer requested a review from a team as a code owner January 13, 2024 14:22
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer enabled auto-merge (squash) January 13, 2024 22:50
@JorTurFer JorTurFer merged commit 88fe3aa into kedacore:main Jan 13, 2024
19 checks passed
@JorTurFer JorTurFer deleted the fix-jetstream-flaky branch January 13, 2024 23:01
sguruvar pushed a commit to sguruvar/keda that referenced this pull request Jan 15, 2024
* chore: fix jetstream flaky test

Signed-off-by: Jorge Turrado <[email protected]>

* use specific instances instead of default client

Signed-off-by: Jorge Turrado <[email protected]>

* Update mock responses

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Siva Guruvareddiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants