Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PR bot fails due to mixing action triggers #5376

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: PR bot fails due to mixing action triggers #5376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr-welcome.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
name: PR Bot
runs-on: ubuntu-latest
steps:
- name: 'Add welcome comment on PR (draft)'
- name: 'Add welcome comment on PR #${{ github.event.number }} (draft)'
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7
if: "github.event.pull_request.draft"
if: github.event_name == 'pull_request_target' && github.event.pull_request.draft
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
Expand All @@ -29,9 +29,9 @@ jobs:
issue_number: ${{ github.event.number }},
body: 'Thank you for your contribution! 🙏 Let us know when you are ready for a review by publishing the PR.'
});
- name: 'Add welcome comment on PR'
- name: 'Add welcome comment on PR #${{ github.event.number }}'
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7
if: "!github.event.pull_request.draft"
if: github.event_name == 'pull_request_target' && !github.event.pull_request.draft
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
Expand All @@ -43,7 +43,7 @@ jobs:
});
- name: 'Apply review required label'
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7
if: "!github.event.pull_request.draft"
if: github.event_name == 'pull_request_review' && (github.event.review.state != 'submitted' || github.event.review.state != 'edited')
with:
script: |
github.rest.issues.addLabels({
Expand Down
Loading