Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-runner-scaler) Add support for key authentication against GHES #5384

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

Eddman
Copy link
Contributor

@Eddman Eddman commented Jan 16, 2024

Current implementation is unable to use GitHub App private key to authenticate against custom API endpoint, eg. GitHub Enterprise Server (GHES).

Based on the https://github.com/bradleyfalzon/ghinstallation?tab=readme-ov-file#github-enterprise-example docs I'm adding support for GHES for authentication using GitHub App private key.

Checklist

Fixes #5387.

@Eddman Eddman requested a review from a team as a code owner January 16, 2024 16:28
@JorTurFer
Copy link
Member

JorTurFer commented Jan 16, 2024

/run-e2e github
Update: You can check the progress here

@JorTurFer
Copy link
Member

Thanks for the fix! ❤️

@JorTurFer JorTurFer enabled auto-merge (squash) January 16, 2024 16:30
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Could you please open a short issue to describe the problem and update Changelog (Fixes in 2.13)?

Thanks!

@Eddman
Copy link
Contributor Author

Eddman commented Jan 16, 2024

@zroubalik Hi, issue created, changelog modified.

When can we expect 2.13 to be released?

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik
Copy link
Member

@zroubalik Hi, issue created, changelog modified.

When can we expect 2.13 to be released?

Thanks!

Our plan is this Thursday.

@zroubalik
Copy link
Member

zroubalik commented Jan 16, 2024

/run-e2e github
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) January 16, 2024 17:05
@zroubalik zroubalik merged commit 8f3e0d6 into kedacore:main Jan 16, 2024
20 checks passed
@Eddman Eddman deleted the patch-1 branch January 17, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github-runner-scaler is unable to work with custom API endpoint
3 participants