-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(github-runner-scaler) Add support for key authentication against GHES #5384
Conversation
Signed-off-by: Adam Netočný <[email protected]>
/run-e2e github |
Thanks for the fix! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Could you please open a short issue to describe the problem and update Changelog (Fixes in 2.13)?
Thanks!
Signed-off-by: Adam Netočný <[email protected]>
@zroubalik Hi, issue created, changelog modified. When can we expect 2.13 to be released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! Our plan is this Thursday. |
/run-e2e github |
Current implementation is unable to use GitHub App private key to authenticate against custom API endpoint, eg. GitHub Enterprise Server (GHES).
Based on the https://github.com/bradleyfalzon/ghinstallation?tab=readme-ov-file#github-enterprise-example docs I'm adding support for GHES for authentication using GitHub App private key.
Checklist
Fixes #5387.