fix(GCP pubsub) - activationValue should use greater than or equal too operator #5386

DP19 · 2024-01-16T16:30:26Z

GCP pub/sub scaler now includes activationValue instead of using greater than logic

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5383

… activationValue Signed-off-by: David Pait <[email protected]>

Signed-off-by: David Pait <[email protected]>

DP19 requested a review from a team as a code owner January 16, 2024 16:30

DP19 added 2 commits January 16, 2024 11:36

update conditional logic for is active to be greater than or equal to…

b13dc65

… activationValue Signed-off-by: David Pait <[email protected]>

set default activationValue to 1

3ff0227

Signed-off-by: David Pait <[email protected]>

DP19 force-pushed the fix-gcp-pubsub-activationValue branch from 88f1abd to 3ff0227 Compare January 16, 2024 16:37

DP19 closed this Jan 16, 2024

DP19 deleted the fix-gcp-pubsub-activationValue branch January 16, 2024 19:06

Provide feedback