[WIP] Generic parameter parser for scalers #5388
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to further improve the work related to refactoring of scalers accomplished by #5319 and #5228. This depends on #5319 and requires a rebase after that PR merges first because this contains commits from that PR.
All unique changes proposed here are in the last commit f03313c can be summarized in following points:
getParameterFromConfigV2
in favour of genericsgetParameterFromConfigV2
with types not supported byconvertToType
during compile timethis means following invocation changes from
to slightly simpler
Checklist
Relates to #5037