Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username from env mysql scaler #5952

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Add username from env mysql scaler #5952

merged 8 commits into from
Jul 22, 2024

Conversation

Indresh2410
Copy link
Contributor

@Indresh2410 Indresh2410 commented Jul 7, 2024 •
edited
Loading

Provide a description of what has been changed

Checklist

Fixes #5883

Relates to #5883

Docs PR: kedacore/keda-docs#1419

@Indresh2410 Indresh2410 requested a review from a team as a code owner July 7, 2024 11:40
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 7, 2024
View reviewed changes
pkg/scalers/scaler.go Fixed Show fixed Hide fixed
Indresh2410
Indresh2410 commented Jul 7, 2024
View reviewed changes
pkg/scalers/scaler.go Outdated Show resolved Hide resolved
@Indresh2410
Refactor scaler switch block
d7efc69 
Signed-off-by: Indresh2410 <[email protected]>
@Indresh2410
Refactor method
322bba0 
Signed-off-by: Indresh2410 <[email protected]>
@SpiritZhou
Copy link
Contributor

Could you mind to refactor this mysql scaler to new declarative scaler config (#5797) ? Then we don't need to add a new function GetFromAuthOrMetaOrEnv.

@Indresh2410
Refactor Mysql Scaler
1cf2e01 
Signed-off-by: Indresh2410 <[email protected]>
@Indresh2410
Copy link
Contributor Author

Could you mind to refactor this mysql scaler to new declarative scaler config (#5797) ? Then we don't need to add a new function GetFromAuthOrMetaOrEnv.

Thanks @SpiritZhou . Have addressed it

wozniakjan
wozniakjan reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only one minor fix below

pkg/scalers/mysql_scaler.go Outdated Show resolved Hide resolved
@Indresh2410
Address Review Comments
62dc49c 
Signed-off-by: Indresh2410 <[email protected]>
@wozniakjan
Copy link
Member

ptal @kedacore/keda-core-contributors, lgtm

@JorTurFer
Copy link
Member

JorTurFer commented Jul 22, 2024 •
edited by github-actions bot
Loading

/run-e2e mysql
Update: You can check the progress here

@JorTurFer
Copy link
Member

Sorry for the slow response, LGTM! ❤️
Once the docs comment is address we can merge the PR :)

@JorTurFer JorTurFer merged commit 817821f into kedacore:main Jul 22, 2024
20 checks passed
@wozniakjan wozniakjan mentioned this pull request Oct 21, 2024
Open
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan Awaiting requested review from wozniakjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get username from Env for MYSQL scaler
4 participants
@Indresh2410 @SpiritZhou @wozniakjan @JorTurFer