Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beanstalkd scaler #6081

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Add beanstalkd scaler #6081

merged 10 commits into from
Nov 5, 2024

Conversation

sbarnesthornton
Copy link
Contributor

@sbarnesthornton sbarnesthornton commented Aug 15, 2024

Adds a new scaler for beanstalkd queues (https://github.com/beanstalkd/beanstalkd). It scales based on the total job count of reserved and ready jobs by default, with the option to add delayed jobs as well.

Both unit tests and integration tests have been added.

Checklist

Fixes to #5901

Relates to #1454

@sbarnesthornton sbarnesthornton requested a review from a team as a code owner August 15, 2024 15:42
Sam Barnes-Thornton added 2 commits August 15, 2024 15:49
Signed-off-by: Sam Barnes-Thornton <[email protected]>

Adds a new scaler for beanstalkd queues, along with necessary tests.

Signed-off-by: Sam Barnes-Thornton <[email protected]>
Signed-off by: Sam Barnes-Thornton <[email protected]>

Signed-off-by: Sam Barnes-Thornton <[email protected]>
Signed-off-by: Sam Barnes-Thornton <[email protected]>
Signed-off-by: Sam Barnes-Thornton <[email protected]>
Sam Barnes-Thornton and others added 2 commits August 19, 2024 08:31
CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Aug 21, 2024

/run-e2e beanstalkd
Update: You can check the progress here

Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: sbarnesthornton <[email protected]>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a comment related with e2e test

tests/scalers/beanstalkd/beanstalkd_test.go Show resolved Hide resolved
Signed-off-by: Sam Barnes-Thornton <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Sep 2, 2024

/run-e2e beanstalkd
Update: You can check the progress here

Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: sbarnesthornton <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Oct 6, 2024

/run-e2e beanstalkd
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the super slow response...

LGTM! Thanks for the scaler ❤️

PTAL @zroubalik @wozniakjan

@JorTurFer JorTurFer mentioned this pull request Nov 3, 2024
28 tasks
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Zbynek Roubalik <[email protected]>
@zroubalik zroubalik merged commit 2f66865 into kedacore:main Nov 5, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants