Add new gitlab-runner-scaler #6087

fira42073 · 2024-08-17T16:27:03Z

Provide a description of what has been changed

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5616

fira42073 · 2024-08-17T22:53:58Z

https://docs.gitlab.com/ee/api/pipelines.html#list-project-pipelines

pkg/scalers/gitlab_runner_scaler.go

Signed-off-by: Fira Curie <[email protected]>

… "waiting for resource" status Signed-off-by: Fira Curie <[email protected]>

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Fira Curie <[email protected]>

* chore: Prepare v2.15.1 Signed-off-by: Jorge Turrado <[email protected]> * fix changelog Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Fira Curie <[email protected]>

* chore: Enable Az Pipeline e2e Signed-off-by: Jorge Turrado <[email protected]> * update manifests Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Fira Curie <[email protected]>

Signed-off-by: Fira Curie <[email protected]>

* chore: Improve azure e2e coverage Signed-off-by: Jorge Turrado <[email protected]> * add missing vars Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Fira Curie <[email protected]>

…dacore#6072) * Update Signed-off-by: SpiritZhou <[email protected]> * Update ChangeLog Signed-off-by: SpiritZhou <[email protected]> * Update Signed-off-by: SpiritZhou <[email protected]> --------- Signed-off-by: SpiritZhou <[email protected]> Signed-off-by: Fira Curie <[email protected]>

) Signed-off-by: Rick Brouwer <[email protected]> Signed-off-by: Fira Curie <[email protected]>

* add errorWhenMetricValueEmpty Signed-off-by: Rob Pickerill <[email protected]> * fix golangci-lint Signed-off-by: Rob Pickerill <[email protected]> * improve error message for empty results Signed-off-by: Rob Pickerill <[email protected]> * add error when empty metric values to changelog Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * use getParameterFromConfigV2 to read config for errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * add e2e for error state for cw, and improve e2e for min values for cw Signed-off-by: Rob Pickerill <[email protected]> * remove erroneous print statement Signed-off-by: Rob Pickerill <[email protected]> * remove unused vars Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * move towards shared package for e2e aws Signed-off-by: Rob Pickerill <[email protected]> * minMetricValue optionality based on ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * fail fast Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Apply suggestions from code review Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fail fast Signed-off-by: Rob Pickerill <[email protected]> * fix broken new line Signed-off-by: Rob Pickerill <[email protected]> * fix broken new lines Signed-off-by: Rob Pickerill <[email protected]> * assert no scaling changes in e2e, and set false for required in minMetricValue Signed-off-by: robpickerill <[email protected]> * fix ci checks Signed-off-by: robpickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go fix invalid check Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fix merge conflicts Signed-off-by: robpickerill <[email protected]> * fix e2e package names Signed-off-by: robpickerill <[email protected]> --------- Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: robpickerill <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Fira Curie <[email protected]>

* add a static connection name Signed-off-by: robpickerill <[email protected]> * Update pkg/scalers/rabbitmq_scaler.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * add improvement to changelog Signed-off-by: robpickerill <[email protected]> * add namepace and so name to conn name Signed-off-by: robpickerill <[email protected]> * Update comment Signed-off-by: Jorge Turrado Ferrero <[email protected]> --------- Signed-off-by: robpickerill <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Fira Curie <[email protected]>

Signed-off-by: Fira Curie <[email protected]>

fira42073 · 2024-08-25T22:45:07Z

I don't know why, but I'm shown as coauthor of some commits that I haven't been a part of.

wozniakjan · 2024-08-26T16:07:01Z

pkg/scalers/scalersconfig/typed_config.go

+func setConfigValueURL(_ Params, valFromConfig string, field reflect.Value) error {
+	u, err := url.Parse(valFromConfig)
+	if err != nil {
+		return fmt.Errorf("expected url.URL or *url.URL, unable to parse %q: %w", valFromConfig, err)
+	}
+
+	// If the field type is a pointer to url.URL (`*url.URL`), set the value directly
+	if field.Kind() == reflect.Ptr && field.Type().Elem() == reflect.TypeOf(url.URL{}) {
+		field.Set(reflect.ValueOf(u))
+		return nil
+	}
+
+	return nil
+}


can you please add a simple unit test for this? you can take an inspiration in

keda/pkg/scalers/scalersconfig/typed_config_test.go

Line 27 in 5b7a372

func TestBasicTypedConfig(t *testing.T) {

wozniakjan · 2024-08-26T16:10:28Z

pkg/scalers/scalersconfig/typed_config.go

@@ -273,6 +273,22 @@ func setConfigValueURLParams(params Params, valFromConfig string, field reflect.
 	return nil
 }

+// setConfigValueURL is a function that sets the value of the url.URL field
+func setConfigValueURL(_ Params, valFromConfig string, field reflect.Value) error {


per our discussion in #5616 (comment), you don't have to pass arguments that the function body doesn't need

Suggested change

func setConfigValueURL(_ Params, valFromConfig string, field reflect.Value) error {

func setConfigValueURL(valFromConfig string, field reflect.Value) error {

Thanks! Fixed that

…b scaler; apply code review suggestions Signed-off-by: Fira Curie <[email protected]>

… gitlab-runner-scaler

stale · 2024-11-07T02:06:45Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

fira42073 changed the title ~~Add new gitlab-runner-scaler; bootstrap configuration~~ Add new gitlab-runner-scaler Aug 17, 2024

fira42073 force-pushed the gitlab-runner-scaler branch from 62e89d9 to 1bc0dd1 Compare August 17, 2024 21:43

zroubalik reviewed Aug 19, 2024

View reviewed changes

pkg/scalers/gitlab_runner_scaler.go Show resolved Hide resolved

pkg/scalers/gitlab_runner_scaler.go Outdated Show resolved Hide resolved

fira42073 and others added 15 commits August 26, 2024 00:44

Add new gitlab-runner-scaler; bootstrap configuration

85410d6

Signed-off-by: Fira Curie <[email protected]>

Query gitlab (with pagination) to find out the number of pipelines in…

b922d62

… "waiting for resource" status Signed-off-by: Fira Curie <[email protected]>

Introduce ClusterCloudEventSource (kedacore#5816)

10ee5bd

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Fira Curie <[email protected]>

chore: Prepare v2.15.1 (kedacore#6051)

3975b8c

* chore: Prepare v2.15.1 Signed-off-by: Jorge Turrado <[email protected]> * fix changelog Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Fira Curie <[email protected]>

change config to declarative format

b186765

Signed-off-by: Fira Curie <[email protected]>

Refactor IBM MQ scaler and remove and deprecate variables (kedacore#6034

9c08822

) Signed-off-by: Rick Brouwer <[email protected]> Signed-off-by: Fira Curie <[email protected]>

add capability to parse *url.URL

6015f2d

Signed-off-by: Fira Curie <[email protected]>

fix config parsing panic due to private fields

47140fe

Signed-off-by: Fira Curie <[email protected]>

add tests

e501824

Signed-off-by: Fira Curie <[email protected]>

fix scaler ordering

0de7956

Signed-off-by: Fira Curie <[email protected]>

fira42073 force-pushed the gitlab-runner-scaler branch from 9c9782b to 0de7956 Compare August 25, 2024 22:44

Merge branch 'main' into gitlab-runner-scaler

5b7a372

wozniakjan mentioned this pull request Aug 26, 2024

GitLab Runner Scaler #5616

Open

wozniakjan reviewed Aug 26, 2024

View reviewed changes

fira42073 added 2 commits August 27, 2024 08:43

add a simple unit test for url.URL parsing; fix broken tests in gitla…

285de8b

…b scaler; apply code review suggestions Signed-off-by: Fira Curie <[email protected]>

Merge branch 'gitlab-runner-scaler' of github.com:fira42073/keda into…

b7e4616

… gitlab-runner-scaler

fira42073 requested a review from wozniakjan August 27, 2024 06:44

fira42073 added 2 commits August 29, 2024 12:16

Merge branch 'main' into gitlab-runner-scaler

98ba6d5

Merge branch 'main' into gitlab-runner-scaler

da1677d

stale bot added the stale All issues that are marked as stale due to inactivity label Nov 7, 2024

Merge branch 'main' into gitlab-runner-scaler

3cfd7bc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new gitlab-runner-scaler #6087

Add new gitlab-runner-scaler #6087

fira42073 commented Aug 17, 2024 •

edited

Loading

fira42073 commented Aug 17, 2024

fira42073 commented Aug 25, 2024

wozniakjan Aug 26, 2024

fira42073 Aug 27, 2024

wozniakjan Aug 26, 2024

fira42073 Aug 27, 2024

stale bot commented Nov 7, 2024

	func setConfigValueURL(_ Params, valFromConfig string, field reflect.Value) error {
	func setConfigValueURL(valFromConfig string, field reflect.Value) error {

Add new gitlab-runner-scaler #6087

Are you sure you want to change the base?

Add new gitlab-runner-scaler #6087

Conversation

fira42073 commented Aug 17, 2024 • edited Loading

Checklist

fira42073 commented Aug 17, 2024

fira42073 commented Aug 25, 2024

wozniakjan Aug 26, 2024

Choose a reason for hiding this comment

fira42073 Aug 27, 2024

Choose a reason for hiding this comment

wozniakjan Aug 26, 2024

Choose a reason for hiding this comment

fira42073 Aug 27, 2024

Choose a reason for hiding this comment

stale bot commented Nov 7, 2024

fira42073 commented Aug 17, 2024 •

edited

Loading