Refactor elasticsearch scaler config #6101
Merged
Task list completed / task-list-completed
succeeded
Sep 26, 2024 in 0s
4 / 4 tasks completed
All tasks have been completed
Details
Required Tasks
Task | Status |
---|---|
Refactor the scaler to match the new metadata guidelines. | Incomplete |
Because i deleted const defaultUnsafeSsl = false in the elasticseach_scaler.go , kafka_scaler.go is giving error pkg/scalers/kafka_scaler.go:354:19: undefined: defaultUnsafeSsl . That's why I added the const in kafka_scaler.go . |
Incomplete |
Extra check if both username and password are provided when addresses is used (also test added). |
Incomplete |
Made a new splitWithSeparator function so the separator is configurable. |
Incomplete |
The documentation states that the field index is comma separated. In the code it is semicolon. There is a separate PR created in the keda-docs repo (1465). | Incomplete |
I have verified that my change is according to the deprecations & breaking changes policy | Completed |
Tests have been added | Completed |
A PR is opened to update the documentation on (repo) (if applicable) | Completed |
Commits are signed with Developer Certificate of Origin (DCO - learn more) | Completed |
Loading