Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor elasticsearch scaler config #6101

Merged
merged 4 commits into from
Sep 26, 2024

Merge branch 'main' into elastic

30eb25e
Select commit
Loading
Failed to load commit list.
Merged

Refactor elasticsearch scaler config #6101

Merge branch 'main' into elastic
30eb25e
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Sep 26, 2024 in 0s

4 / 4 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Refactor the scaler to match the new metadata guidelines. Incomplete
Because i deleted const defaultUnsafeSsl = false in the elasticseach_scaler.go, kafka_scaler.go is giving error pkg/scalers/kafka_scaler.go:354:19: undefined: defaultUnsafeSsl. That's why I added the const in kafka_scaler.go. Incomplete
Extra check if both username and password are provided when addresses is used (also test added). Incomplete
Made a new splitWithSeparator function so the separator is configurable. Incomplete
The documentation states that the field index is comma separated. In the code it is semicolon. There is a separate PR created in the keda-docs repo (1465). Incomplete
I have verified that my change is according to the deprecations & breaking changes policy Completed
Tests have been added Completed
A PR is opened to update the documentation on (repo) (if applicable) Completed
Commits are signed with Developer Certificate of Origin (DCO - learn more) Completed