Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cert-controller deps #6274

Closed
wants to merge 2 commits into from

Conversation

smcavallo
Copy link
Contributor

Signed-off-by: smcavallo [email protected]

Updating cert-controller dependencies and overriding the replace in the go.mod

Per the note in the go.mod -> Remove this when they merge the PR and cut a release open-policy-agent/cert-controller#202
The above change has been merged and a release has been cut.
See - https://github.com/open-policy-agent/cert-controller/releases/tag/v0.11.0

Updating to use the new version and removing the override.

Checklist

  • [X ] When introducing a new scaler, I agree with the scaling governance policy
  • [X ] I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • [X ] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

@smcavallo smcavallo requested a review from a team as a code owner October 26, 2024 21:26
Signed-off-by: smcavallo <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Nov 2, 2024

Thanks for the PR! I close it because we are bumping the deps (PR incoming) and this is the new PR that needs to be merged and shipped to remove our replacement -> open-policy-agent/cert-controller#281
Until that PR is merged and released, we need to keep the replacement

@JorTurFer JorTurFer closed this Nov 2, 2024
@smcavallo
Copy link
Contributor Author

@JorTurFer - thanks so much for doing that. I am actually trying to make other code changes, and I am having a difficult time building the project due to some of these dependencies. I have no direct interest in updating this dependency, it's just blocking some of the other changes I was hoping to contribute. I'll wait until this PR is merged and I think this should resolve all the issues -> #6305 Thanks again for taking care of all that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants