Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github.com/dgrijalva/jwt-go from replace as it is not getting used anywhere #6315

Closed

Conversation

debasishbsws
Copy link

@debasishbsws debasishbsws commented Nov 6, 2024

Provide a description of what has been changed

Remove github.com/dgrijalva/jwt-go from replace as it is not getting used anywhere

The module
is not getting used anywhere but it is mentioned in the go.mod file and now it causing error when we try to update the github.com/golang-jwt/jwt/v4 which is getting
used error: go: github.com/golang-jwt/jwt/[email protected] used for two different module paths (github.com/dgrijalva/jwt-go and github.com/golang-jwt/jwt/v4)

Checklist

Fixes #

Relates to #

…etting used anywhere

The module is not getting used anywhere but it is mentioned in the go.mod file and now it causing error when we try to update the github.com/golang-jwt/jwt/v4 which is getting used error:

Signed-off-by: debasishbsws <[email protected]>
Signed-off-by: debasishbsws <[email protected]>
@debasishbsws debasishbsws changed the title chore: Remove github.com/dgrijalva/jwt-go from replace as it is not getting used anywhere Remove github.com/dgrijalva/jwt-go from replace as it is not getting used anywhere Nov 6, 2024
@JorTurFer
Copy link
Member

Hello
Thanks for reporting the issue. Actually github.com/dgrijalva/jwt-go is used as transitory dependency of github.com/spf13/viper with is a transitory dependency of github.com/spf13/cobra, so sadly it's in use and that's why we added the replace statement.
I have this other PR opened with a lot of bumps, preparing tomorrow's release. I have included a bump of this dep to fix the issue -> fba853a (#6305)

@JorTurFer JorTurFer closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants