Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add global connection pool for mysql #6327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add global connection pool for mysql #6327

wants to merge 1 commit into from

Conversation

robpickerill
Copy link
Contributor

Adds a global connection pool for MySQL, supporting #6314

Checklist

Fixes #6314

Relates to #

@robpickerill robpickerill requested a review from a team as a code owner November 10, 2024 13:27
@robpickerill robpickerill force-pushed the global-mysql-conn-pool branch 6 times, most recently from 218e3c9 to 52f5ef4 Compare November 10, 2024 16:48
robpickerill
robpickerill commented Nov 10, 2024
View reviewed changes
pkg/scalers/mysql_scaler.go
// setConnectionPoolConfiguration configures the MySQL connection pool settings
// based on the parameters provided in mySQLMetadata. If a setting is zero, it
// is left at its default value.
func setConnectionPoolConfiguration(meta *mySQLMetadata, db *sql.DB) {
Copy link
Contributor Author

@robpickerill robpickerill Nov 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Reconcile these values when scalers share pools but present different connection pool settings

  • select max/min/etc
  • OR create new connection and add to pool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement connectionPool into mysql scaler based on grpc connectionPool
1 participant
@robpickerill