Add KEDAScalersInfo to display important information #6330
+104
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickbrouwer
force-pushed
the
scalerinfo
branch
5 times, most recently
from
ee11028
to
0fef06b
Compare
wozniakjan
reviewed
Nov 13, 2024
There was a problem hiding this comment.
would it be possible to include these events in the TypedConfig deprecated logic?
I can imagine we may want to add something like "DeprecatedEvent" parameter to model this behaviour, because iirc the "Deprecated" parameter present there will error the scaler parsing. Or maybe we change the current behaviour to not fail and throw event instead?
| @@ -58,7 +66,6 @@ func parseResourceMetadata(config *scalersconfig.ScalerConfig, logger logr.Logge | |||
|
|
|||
| // This is deprecated and can be removed later | |||
| if meta.Type != "" { | |||
| logger.Info("The 'type' setting is DEPRECATED and will be removed in v2.18 - Use 'metricType' instead.") | |||
There was a problem hiding this comment.
nit: does it make sense to keep both events as well as log messages regarding deprecated fields?
There was a problem hiding this comment.
I think it make sense to keep both
rickbrouwer
force-pushed
the
scalerinfo
branch
5 times, most recently
from
9a79002
to
81e6f6c
Compare
Signed-off-by: rickbrouwer <[email protected]>
rickbrouwer
force-pushed
the
scalerinfo
branch
from
81e6f6c
to
be3da81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new event (KEDAScalersInfo) so that important information is shown in e.g. Argo CD.
Added the deprecation info message by the
cpu_memory_scalerandibmmq_scaler.Checklist
Fixes #6328