Checkfallbackvalid #6407

ctccxxd · 2024-12-07T15:39:29Z

Revise some annotations and fix fallback check, originally,
1, Annotations above function is not well
2, Fallback check does not take effect
3, validate the case fallback with cpu/memory

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

related issue
#6355

Signed-off-by: Shane <[email protected]>

ctccxxd · 2024-12-07T15:50:23Z

Friendly ping @wozniakjan @JorTurFer I have follow your idea to validate the case fallback with cpu/memory, hope your review, much thanks.

Signed-off-by: Shane <[email protected]>

JorTurFer · 2024-12-15T16:12:31Z

/run-e2e internal
Update: You can check the progress here

ctccxxd · 2024-12-17T00:09:00Z

Here e2e test failed , but I can't see the detail and what happened. Please have a look at this , thank you. @JorTurFer @zroubalik

JorTurFer · 2024-12-22T15:23:46Z

/run-e2e internal
Update: You can check the progress here

ctccxxd · 2024-12-23T01:43:23Z

Here e2e test failed again, but I still can't see the detail and what happened. Please have a look at this , thank you. @JorTurFer @zroubalik

SpiritZhou · 2024-12-23T07:35:16Z

@ctccxxd Here is the error.

2024-12-22T16:11:46.8675696Z tests/internals/fallback/fallback_test.go has failed after "three" attempts 
2024-12-22T16:11:46.8676438Z attempt number "one"
2024-12-22T16:11:46.8676879Z === RUN   TestFallback
2024-12-22T16:11:46.8677397Z     fallback_test.go:***: --- setting up ---
2024-12-22T16:11:46.8677980Z     helper.go:***47: deleting namespace fallback-test-ns
2024-12-22T16:11:46.8678585Z     helper.go:***0***: waiting for namespace fallback-test-ns deletion
2024-12-22T16:11:46.8679143Z     helper.go:***4: Creating namespace - fallback-test-ns
2024-12-22T16:11:46.8679686Z     helper.go:54***: Applying template: secretTemplate
2024-12-22T16:11:46.8680524Z     helper.go:54***: Applying template: metricsServerDeploymentTemplate
2024-12-22T16:11:46.8681079Z     helper.go:54***: Applying template: serviceTemplate
2024-12-22T16:11:46.8681691Z     helper.go:54***: Applying template: triggerAuthenticationTemplate
2024-12-22T16:11:46.8682255Z     helper.go:54***: Applying template: deploymentTemplate
2024-12-22T16:11:46.8682826Z     helper.go:54***: Applying template: scaledObjectTemplate
2024-12-22T16:11:46.8683264Z     helper.go:555: 
2024-12-22T16:11:46.8683838Z         	Error Trace:	/__w/keda/keda/tests/helper/helper.go:555
2024-12-22T16:11:46.8684378Z         	            				/__w/keda/keda/tests/helper/helper.go:584
2024-12-22T16:11:46.8684913Z         	            				/__w/keda/keda/tests/helper/helper.go:656
2024-12-22T16:11:46.8685555Z         	            				/__w/keda/keda/tests/internals/fallback/fallback_test.go:***4
2024-12-22T16:11:46.8686053Z         	Error:      	Received unexpected error:
2024-12-22T16:11:46.8687656Z         	            	Error from server (Forbidden): error when creating "/tmp/scaledObjectTemplate8475697***8": admission webhook "vscaledobject.kb.io" denied the request: MetricType=, but fallback can only be enabled for triggers with metric of type AverageValue
2024-12-22T16:11:46.8688403Z         	Test:       	TestFallback
2024-12-22T16:11:46.8690192Z         	Messages:   	cannot apply file - Error from server (Forbidden): error when creating "/tmp/scaledObjectTemplate8475697***8": admission webhook "vscaledobject.kb.io" denied the request: MetricType=, but fallback can only be enabled for triggers with metric of type AverageValue

Signed-off-by: Shane <[email protected]>

ctccxxd · 2024-12-23T14:02:33Z

@ctccxxd Here is the error.

2024-12-22T16:11:46.8675696Z tests/internals/fallback/fallback_test.go has failed after "three" attempts 
2024-12-22T16:11:46.8676438Z attempt number "one"
2024-12-22T16:11:46.8676879Z === RUN   TestFallback
2024-12-22T16:11:46.8677397Z     fallback_test.go:***: --- setting up ---
2024-12-22T16:11:46.8677980Z     helper.go:***47: deleting namespace fallback-test-ns
2024-12-22T16:11:46.8678585Z     helper.go:***0***: waiting for namespace fallback-test-ns deletion
2024-12-22T16:11:46.8679143Z     helper.go:***4: Creating namespace - fallback-test-ns
2024-12-22T16:11:46.8679686Z     helper.go:54***: Applying template: secretTemplate
2024-12-22T16:11:46.8680524Z     helper.go:54***: Applying template: metricsServerDeploymentTemplate
2024-12-22T16:11:46.8681079Z     helper.go:54***: Applying template: serviceTemplate
2024-12-22T16:11:46.8681691Z     helper.go:54***: Applying template: triggerAuthenticationTemplate
2024-12-22T16:11:46.8682255Z     helper.go:54***: Applying template: deploymentTemplate
2024-12-22T16:11:46.8682826Z     helper.go:54***: Applying template: scaledObjectTemplate
2024-12-22T16:11:46.8683264Z     helper.go:555: 
2024-12-22T16:11:46.8683838Z         	Error Trace:	/__w/keda/keda/tests/helper/helper.go:555
2024-12-22T16:11:46.8684378Z         	            				/__w/keda/keda/tests/helper/helper.go:584
2024-12-22T16:11:46.8684913Z         	            				/__w/keda/keda/tests/helper/helper.go:656
2024-12-22T16:11:46.8685555Z         	            				/__w/keda/keda/tests/internals/fallback/fallback_test.go:***4
2024-12-22T16:11:46.8686053Z         	Error:      	Received unexpected error:
2024-12-22T16:11:46.8687656Z         	            	Error from server (Forbidden): error when creating "/tmp/scaledObjectTemplate8475697***8": admission webhook "vscaledobject.kb.io" denied the request: MetricType=, but fallback can only be enabled for triggers with metric of type AverageValue
2024-12-22T16:11:46.8688403Z         	Test:       	TestFallback
2024-12-22T16:11:46.8690192Z         	Messages:   	cannot apply file - Error from server (Forbidden): error when creating "/tmp/scaledObjectTemplate8475697***8": admission webhook "vscaledobject.kb.io" denied the request: MetricType=, but fallback can only be enabled for triggers with metric of type AverageValue

@SpiritZhou @JorTurFer I have fix this case, please run e2e again and check to approve, much thanks.

ctccxxd · 2024-12-23T14:02:47Z

@ctccxxd Here is the error.

2024-12-22T16:11:46.8675696Z tests/internals/fallback/fallback_test.go has failed after "three" attempts 
2024-12-22T16:11:46.8676438Z attempt number "one"
2024-12-22T16:11:46.8676879Z === RUN   TestFallback
2024-12-22T16:11:46.8677397Z     fallback_test.go:***: --- setting up ---
2024-12-22T16:11:46.8677980Z     helper.go:***47: deleting namespace fallback-test-ns
2024-12-22T16:11:46.8678585Z     helper.go:***0***: waiting for namespace fallback-test-ns deletion
2024-12-22T16:11:46.8679143Z     helper.go:***4: Creating namespace - fallback-test-ns
2024-12-22T16:11:46.8679686Z     helper.go:54***: Applying template: secretTemplate
2024-12-22T16:11:46.8680524Z     helper.go:54***: Applying template: metricsServerDeploymentTemplate
2024-12-22T16:11:46.8681079Z     helper.go:54***: Applying template: serviceTemplate
2024-12-22T16:11:46.8681691Z     helper.go:54***: Applying template: triggerAuthenticationTemplate
2024-12-22T16:11:46.8682255Z     helper.go:54***: Applying template: deploymentTemplate
2024-12-22T16:11:46.8682826Z     helper.go:54***: Applying template: scaledObjectTemplate
2024-12-22T16:11:46.8683264Z     helper.go:555: 
2024-12-22T16:11:46.8683838Z         	Error Trace:	/__w/keda/keda/tests/helper/helper.go:555
2024-12-22T16:11:46.8684378Z         	            				/__w/keda/keda/tests/helper/helper.go:584
2024-12-22T16:11:46.8684913Z         	            				/__w/keda/keda/tests/helper/helper.go:656
2024-12-22T16:11:46.8685555Z         	            				/__w/keda/keda/tests/internals/fallback/fallback_test.go:***4
2024-12-22T16:11:46.8686053Z         	Error:      	Received unexpected error:
2024-12-22T16:11:46.8687656Z         	            	Error from server (Forbidden): error when creating "/tmp/scaledObjectTemplate8475697***8": admission webhook "vscaledobject.kb.io" denied the request: MetricType=, but fallback can only be enabled for triggers with metric of type AverageValue
2024-12-22T16:11:46.8688403Z         	Test:       	TestFallback
2024-12-22T16:11:46.8690192Z         	Messages:   	cannot apply file - Error from server (Forbidden): error when creating "/tmp/scaledObjectTemplate8475697***8": admission webhook "vscaledobject.kb.io" denied the request: MetricType=, but fallback can only be enabled for triggers with metric of type AverageValue

@SpiritZhou @JorTurFer I have fixed this case, please run e2e again and check to approve, much thanks. Only depend on #6434 fix.

JorTurFer · 2024-12-23T19:46:04Z

/run-e2e internal
Update: You can check the progress here

SpiritZhou · 2024-12-24T02:21:26Z

@ctccxxd caling_modifiers_test test case also has the same error.

Signed-off-by: Shane <[email protected]>

ctccxxd · 2024-12-24T02:33:14Z

@ctccxxd caling_modifiers_test test case also has the same error.

xPassed tests:
Execution of tests/internals/scaled_job_validation/scaled_job_validation_test.go, has passed after "one" attempts
Execution of tests/internals/trigger_authentication_validation/trigger_authentication_validation_test.go, has passed after "one" attempts
Execution of tests/internals/status_update/status_update_test.go, has passed after "one" attempts
Execution of tests/internals/scaled_object_validation/scaled_object_validation_test.go, has passed after "one" attempts
Execution of tests/internals/restore_original/restore_original_test.go, has passed after "one" attempts
Execution of tests/internals/idle_replicas/idle_replicas_test.go, has passed after "one" attempts
Execution of tests/internals/min_replica_sj/min_replica_sj_test.go, has passed after "one" attempts
Execution of tests/internals/custom_hpa_name/custom_hpa_name_test.go, has passed after "one" attempts
Execution of tests/internals/scaling_strategies/eager_scaling_strategy_test.go, has passed after "one" attempts
Execution of tests/internals/value_metric_type/value_metric_type_test.go, has passed after "one" attempts
Execution of tests/internals/global_custom_ca/global_custom_ca_test.go, has passed after "one" attempts
Execution of tests/internals/subresource_scale/subresource_scale_test.go, has passed after "one" attempts
Execution of tests/internals/eventemitter/azureeventgridtopic/azureeventgridtopic_test.go, has passed after "three" attempts
Execution of tests/internals/events/events_test.go, has passed after "one" attempts
Execution of tests/internals/update_ta/update_ta_test.go, has passed after "one" attempts
Execution of tests/internals/pause_scaledobject/pause_scaledobject_test.go, has passed after "one" attempts
Execution of tests/internals/replica_update_so/replica_update_so_test.go, has passed after "one" attempts
Execution of tests/internals/initial_delay_cooldownperiod/initial_delay_cooldownperiod_test.go, has passed after "one" attempts
Execution of tests/internals/trigger_update_so/trigger_update_so_test.go, has passed after "one" attempts
Execution of tests/internals/cache_metrics/cache_metrics_test.go, has passed after "one" attempts
Execution of tests/internals/cloudevent_source/cloudevent_source_test.go, has passed after "one" attempts
Execution of tests/internals/pause_scaledjob/pause_scaledjob_test.go, has passed after "one" attempts
Execution of tests/internals/fallback/fallback_test.go, has passed after "one" attempts
Execution of tests/internals/polling_cooldown_so/polling_cooldown_so_test.go, has passed after "one" attempts
Execution of tests/internals/pause_scaledobject_explicitly/pause_scaledobject_explicitly_test.go, has passed after "one" attempts
Failed tests:
Execution of tests/internals/scaling_modifiers/scaling_modifiers_test.go, has failed after "three" attempts

@SpiritZhou @JorTurFer scaling_modifiers_test.go error has been fixed, and help me to run e2e test again, and other 25 tests are all ok, thank you

SpiritZhou · 2024-12-24T02:42:49Z

/run-e2e internal
Update: You can check the progress here

ctccxxd · 2024-12-24T03:27:58Z

/run-e2e internal Update: You can check the progress here

Failed tests:
Execution of tests/internals/eventemitter/azureeventgridtopic/azureeventgridtopic_test.go, has failed after "three" attempts
make: *** [Makefile:09: ee-test] Error ***

@JorTurFer Here come this error, seems not related to my PR, and my other PR #6350 also encounter this error, related discuss #6350 (comment). Hope you have a look at this. Much thanks.

ctccxxd added 5 commits November 19, 2024 14:39

revise some object name and fix fallback check

6ae9874

Signed-off-by: Shane <[email protected]>

add changelog

6986e93

Signed-off-by: Shane <[email protected]>

fix CAHNGELOG.MD

55c962b

Signed-off-by: Shane <[email protected]>

put new log in CAHNGELOG.MD fix section

dfeed82

Signed-off-by: Shane <[email protected]>

revise fallback with cpu/memory validation

5256fb1

Signed-off-by: Shane <[email protected]>

ctccxxd requested a review from a team as a code owner December 7, 2024 15:39

revise test case

c52d955

Signed-off-by: Shane <[email protected]>

ctccxxd force-pushed the checkfallbackvalid branch from 5dc6f23 to c52d955 Compare December 7, 2024 16:17

revise value name

dc2477e

Signed-off-by: Shane <[email protected]>

ctccxxd force-pushed the checkfallbackvalid branch from aed658d to dc2477e Compare December 8, 2024 10:01

ctccxxd added 2 commits December 8, 2024 19:54

Merge branch 'main' into checkfallbackvalid

aa64c74

Signed-off-by: Shane <[email protected]>

Update scaledobject_webhook_test.go

649a660

Signed-off-by: Shane <[email protected]>

ctccxxd mentioned this pull request Dec 8, 2024

fix: revise some annnotations and fix fallback check bug #6346

Closed

7 tasks

JorTurFer approved these changes Dec 15, 2024

View reviewed changes

fix fallback test

36c5711

Signed-off-by: Shane <[email protected]>

fix scaling-modifiers-test-ns

0bf46b0

Signed-off-by: Shane <[email protected]>

ctccxxd force-pushed the checkfallbackvalid branch from fd65d91 to 0bf46b0 Compare December 24, 2024 02:27

ctccxxd added 2 commits December 24, 2024 10:28

Update scaling_modifiers_test.go

b95db98

Signed-off-by: Shane <[email protected]>

Update fallback_test.go

59ba78f

Signed-off-by: Shane <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checkfallbackvalid #6407

Checkfallbackvalid #6407

ctccxxd commented Dec 7, 2024 •

edited

Loading

ctccxxd commented Dec 7, 2024 •

edited

Loading

JorTurFer commented Dec 15, 2024 •

edited by github-actions bot

Loading

ctccxxd commented Dec 17, 2024

JorTurFer commented Dec 22, 2024 •

edited by github-actions bot

Loading

ctccxxd commented Dec 23, 2024

SpiritZhou commented Dec 23, 2024

ctccxxd commented Dec 23, 2024

ctccxxd commented Dec 23, 2024 •

edited

Loading

JorTurFer commented Dec 23, 2024 •

edited by github-actions bot

Loading

SpiritZhou commented Dec 24, 2024

ctccxxd commented Dec 24, 2024 •

edited

Loading

SpiritZhou commented Dec 24, 2024 •

edited by github-actions bot

Loading

ctccxxd commented Dec 24, 2024

Checkfallbackvalid #6407

Are you sure you want to change the base?

Checkfallbackvalid #6407

Conversation

ctccxxd commented Dec 7, 2024 • edited Loading

ctccxxd commented Dec 7, 2024 • edited Loading

JorTurFer commented Dec 15, 2024 • edited by github-actions bot Loading

ctccxxd commented Dec 17, 2024

JorTurFer commented Dec 22, 2024 • edited by github-actions bot Loading

ctccxxd commented Dec 23, 2024

SpiritZhou commented Dec 23, 2024

ctccxxd commented Dec 23, 2024

ctccxxd commented Dec 23, 2024 • edited Loading

JorTurFer commented Dec 23, 2024 • edited by github-actions bot Loading

SpiritZhou commented Dec 24, 2024

ctccxxd commented Dec 24, 2024 • edited Loading

SpiritZhou commented Dec 24, 2024 • edited by github-actions bot Loading

ctccxxd commented Dec 24, 2024

ctccxxd commented Dec 7, 2024 •

edited

Loading

ctccxxd commented Dec 7, 2024 •

edited

Loading

JorTurFer commented Dec 15, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Dec 22, 2024 •

edited by github-actions bot

Loading

ctccxxd commented Dec 23, 2024 •

edited

Loading

JorTurFer commented Dec 23, 2024 •

edited by github-actions bot

Loading

ctccxxd commented Dec 24, 2024 •

edited

Loading

SpiritZhou commented Dec 24, 2024 •

edited by github-actions bot

Loading