-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the intersphinx mapping to new datasets URL #4046
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
@@ -69,7 +69,7 @@ | |||
|
|||
intersphinx_mapping = { | |||
"kedro-viz": ("https://docs.kedro.org/projects/kedro-viz/en/v6.6.1/", None), | |||
"kedro-datasets": ("https://docs.kedro.org/projects/kedro-datasets/en/kedro-datasets-2.0.0/", None), | |||
"kedro-datasets": ("https://docs.kedro.org/projects/kedro-datasets/en/kedro-datasets-4.0.0/", None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this should be updated? Again, not super familiar with intersphinx_mapping
; barely looking into it for this investigation.
Because, if update this, sounds like should update a bunch of the other versions, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it, maybe we jump to the next release that's about to be published?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because, if update this, sounds like should update a bunch of the other versions, too.
We can do so in another PR
Signed-off-by: Deepyaman Datta <[email protected]>
Feel free to continue with this one @deepyaman , ping us when it's ready for review |
Description
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file