Fix warnings when integrating via CocoaPods

KeenClient.podspec

@@ -2,7 +2,7 @@ Pod::Spec.new do |spec|
   spec.name         = 'KeenClient'
   spec.version      = '3.7.0'
   spec.license      = { :type => 'MIT' }
-  spec.ios.deployment_target = '6.0'
+  spec.ios.deployment_target = '8.0'
   spec.osx.deployment_target = '10.9'
   spec.homepage     = 'https://github.com/keenlabs/KeenClient-iOS'
 
@@ -23,6 +23,9 @@ Pod::Spec.new do |spec|
   spec.public_header_files = 'KeenClient/*.h'
   spec.requires_arc = true
   spec.frameworks = 'SystemConfiguration', 'CoreLocation', 'CFNetwork'
+  spec.pod_target_xcconfig = {
+    'CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF' => 'NO',
+  }
 
   spec.subspec 'keen_sqlite' do |ks|
     ks.source_files = 'Library/sqlite-amalgamation/*.{h,c}'

KeenClient.xcodeproj/project.pbxproj

@@ -890,7 +890,6 @@
 		0111015814EF71FB009794A5 /* Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
-				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
 				ONLY_ACTIVE_ARCH = NO;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 			};
@@ -899,7 +898,6 @@
 		0111015914EF71FB009794A5 /* Release */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
-				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
 				ONLY_ACTIVE_ARCH = NO;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 			};
@@ -909,6 +907,8 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				COPY_PHASE_STRIP = NO;
 				ENABLE_TESTABILITY = YES;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
@@ -923,7 +923,7 @@
 				GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
 				GCC_WARN_ABOUT_RETURN_TYPE = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
 				ONLY_ACTIVE_ARCH = YES;
 				SDKROOT = iphoneos;
 			};
@@ -933,13 +933,15 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				COPY_PHASE_STRIP = YES;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
 				GCC_VERSION = "";
 				GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
 				GCC_WARN_ABOUT_RETURN_TYPE = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
 				SDKROOT = iphoneos;
 				VALIDATE_PRODUCT = YES;
 			};
@@ -949,6 +951,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
 				DSTROOT = /tmp/KeenClient.dst;
 				GCC_GENERATE_TEST_COVERAGE_FILES = NO;
 				GCC_INSTRUMENT_PROGRAM_FLOW_ARCS = NO;
@@ -957,7 +960,6 @@
 				GCC_PREPROCESSOR_DEFINITIONS = "$(inherited)";
 				"GCC_PREPROCESSOR_DEFINITIONS[arch=*]" = "$(inherited)";
 				GCC_THUMB_SUPPORT = NO;
-				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
 				LIBRARY_SEARCH_PATHS = (
 					"$(inherited)",
 					"\"$(SRCROOT)/Library\"",
@@ -973,11 +975,11 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
 				DSTROOT = /tmp/KeenClient.dst;
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "$(PROJECT_DIR)/KeenClient/KeenClient-Prefix.pch";
 				GCC_THUMB_SUPPORT = NO;
-				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
 				LIBRARY_SEARCH_PATHS = (
 					"$(inherited)",
 					"\"$(SRCROOT)/Library\"",
@@ -1076,7 +1078,6 @@
 				GCC_WARN_UNDECLARED_SELECTOR = YES;
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
 				MACOSX_DEPLOYMENT_TARGET = 10.9;
 				ONLY_ACTIVE_ARCH = NO;
 				PRODUCT_NAME = "$(TARGET_NAME)";
@@ -1114,7 +1115,6 @@
 				GCC_WARN_UNDECLARED_SELECTOR = YES;
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
 				MACOSX_DEPLOYMENT_TARGET = 10.9;
 				ONLY_ACTIVE_ARCH = NO;
 				PRODUCT_NAME = "$(TARGET_NAME)";

KeenClient/KIOUploader.h

@@ -23,6 +23,6 @@
 - (instancetype)initWithNetwork:(KIONetwork *)network andStore:(KIODBStore *)store;
 
 // Upload events in the store for a given project
-- (void)uploadEventsForConfig:(KeenClientConfig *)config completionHandler:(void (^)())completionHandler;
+- (void)uploadEventsForConfig:(KeenClientConfig *)config completionHandler:(void (^)(void))completionHandler;
 
 @end

KeenClient/KIOUploader.m

@@ -20,7 +20,7 @@ @interface KIOUploader ()
 
 - (BOOL)isNetworkConnected;
 
-- (void)runUploadFinishedBlock:(void (^)())block;
+- (void)runUploadFinishedBlock:(void (^)(void))block;
 
 /**
  Handles the HTTP response from the Keen Event API.  This involves deserializing the JSON response
@@ -151,7 +151,7 @@ - (BOOL)isNetworkConnected {
     return [hostReachability KIOcurrentReachabilityStatus] != NotReachable;
 }
 
-- (void)uploadEventsForConfig:(KeenClientConfig *)config completionHandler:(void (^)())completionHandler {
+- (void)uploadEventsForConfig:(KeenClientConfig *)config completionHandler:(void (^)(void))completionHandler {
     dispatch_async(self.uploadQueue, ^{
         if (![self isNetworkConnected]) {
             [self runUploadFinishedBlock:completionHandler];
@@ -207,7 +207,7 @@ - (void)uploadEventsForConfig:(KeenClientConfig *)config completionHandler:(void
     });
 }
 
-- (void)runUploadFinishedBlock:(void (^)())block {
+- (void)runUploadFinishedBlock:(void (^)(void))block {
     if (block) {
         KCLogVerbose(@"Running user-specified block.");
         block();

KeenClient/KeenClient.h

@@ -327,7 +327,7 @@ typedef void (^AnalysisCompletionBlock)(NSData *responseData, NSURLResponse *res
  @param block The block to be executed once uploading is finished, regardless of whether or not the upload succeeded.
  The block is also called when no upload was necessary because no events were captured.
  */
-- (void)uploadWithFinishedBlock:(void (^)())block;
+- (void)uploadWithFinishedBlock:(void (^)(void))block;
 
 /**
  Refresh the current geo location. The Keen Client only gets geo at the beginning of each session (i.e. when the client

KeenClient/KeenClient.m

@@ -340,7 +340,7 @@ - (void)refreshCurrentLocation {
         if ([KeenClient isLocationAuthorized:clAuthStatus]) {
             [self startMonitoringLocation];
         }
-#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 80000
+#if TARGET_OS_IPHONE
         // Else, try and request permission for that.
         else if (geoLocationRequestEnabled &&
                  [self.locationManager respondsToSelector:@selector(requestAlwaysAuthorization)]) {
@@ -378,8 +378,8 @@ + (BOOL)isLocationAuthorized:(CLAuthorizationStatus)status {
 
 // Delegate method from the CLLocationManagerDelegate protocol.
 - (void)locationManager:(CLLocationManager *)manager
-    didUpdateToLocation:(CLLocation *)newLocation
-           fromLocation:(CLLocation *)oldLocation {
+     didUpdateLocations:(NSArray<CLLocation *> *)locations {
+    CLLocation *newLocation = locations.lastObject;
     // If it's a relatively recent event, turn off updates to save power
     NSDate *eventDate = newLocation.timestamp;
     NSTimeInterval howRecent = [eventDate timeIntervalSinceNow];
@@ -563,7 +563,7 @@ - (void)importFileData {
     [KIOFileStore importFileDataWithProjectID:self.config.projectID];
 }
 
-- (void)uploadWithFinishedBlock:(void (^)())block {
+- (void)uploadWithFinishedBlock:(void (^)(void))block {
     [self.uploader uploadEventsForConfig:self.config completionHandler:block];
 }