Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Adds bit rotation to alexandria_math #201

Closed
wants to merge 8 commits into from
Closed

Feat: Adds bit rotation to alexandria_math #201

wants to merge 8 commits into from

Conversation

sveamarcus
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Adds bit rotation to unsigned integers
  • New trait BitRotate
  • fn rotl(..) for rotate bits left
  • fn rotr(..) for rotate bits right

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sveamarcus sveamarcus requested a review from 0xLucqs as a code owner October 25, 2023 13:50
@sveamarcus sveamarcus closed this Nov 9, 2023
@sveamarcus sveamarcus deleted the feat/bit_rotate branch November 9, 2023 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaetbout gaetbout gaetbout approved these changes

@0xLucqs 0xLucqs Awaiting requested review from 0xLucqs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveamarcus @gaetbout