generated from eigerco/beerus
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signed u256 - i257 #236
Merged
Merged
signed u256 - i257 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
requested changes
Jan 5, 2024
0xLucqs
requested changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert the DivRem
plz otherwise lgtm
@LucasLvy Done |
0xLucqs
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
We don't have signed u256.
Issue Number: N/A
What is the new behavior?
We have signed u256.
Does this introduce a breaking change?
Other information
The code and tests for this is largely taken from old i129 int. I've tried to make commits with old pasted code and tweaks made on that commit. Hopefully that will make reviewing easier.
Source: https://github.com/shramee/alexandria/blob/7e0f050b97c42b2a5916d552494d3724ae2c0197/alexandria/math/src/signed_integers.cairo#L1618
Tests come from: https://github.com/shramee/alexandria/blob/7e0f050b97c42b2a5916d552494d3724ae2c0197/alexandria/math/src/tests/signed_integers_test.cairo#L1279