chore: another pixel placement control flow #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vibenedict is attempting to deploy a commit to the keep-starknet-strange Team on Vercel. A member of the Team first needs to authorize it. |
b-j-roberts
requested changes
Jun 6, 2024
There was a problem hiding this comment.
How this is implemented now, here is the user's flow:
- Click the pixel on the canvas when one is available
- Click to select a color from the palette
- Click the same pixel again on the canvas to color it
For a better user experience I think something like this would be better
- Click a pixel on the canvas when one is available
- Click a color on the palette
a. If the user only has one pixel available, submit to color the pixel selected with the color chosen
b. If the user has more than one pixel available, color the pixel the user selected and select the color to use for extra pixels.
| @@ -303,6 +305,11 @@ function App() { | |||
| setSelectedPositionX(x); | |||
| setSelectedPositionY(y); | |||
| setPixelSelectedMode(true); | |||
|
|
|||
| if (placementTimer == 'Place Pixel') { | |||
There was a problem hiding this comment.
Checking against a string here would be bad practice because the string can change. For instance, when the user has multiple pixels, the button says 'Place Pixels' instead.
I'd recommend using availablePixels > 0 for this check.
|
@vibenedict Will you be able to make these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on a pixel in the canvas should open the pixel color selector (if "Place Pixel" button is active)