Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World Names #269

Merged
merged 6 commits into from
Dec 16, 2024
Merged

World Names #269

merged 6 commits into from
Dec 16, 2024

Conversation

supreme2580
Copy link
Contributor

@supreme2580 supreme2580 commented Dec 5, 2024

  • issue #
  • follows contribution guide
  • code change includes tests
  • breaking change
  • Added World Name Validation at the backend to make sure that the incoming world name does not exist
  • Added endpoints on the backend to check if a name exists
  • Created an alternate route to be able to get world by name or world id
  • Added validation to the frontend to make sure that only world addresses that has 1-31 characters and contains letters, numbers, spaces, hyphens, and underscores only are passed to the backend
  • Added UI for error messages
  • Changed the share url from using world Id to using world name

Closes: #268

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
art-peace ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 2:50pm

Copy link

vercel bot commented Dec 5, 2024

@supreme2580 is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks!

@b-j-roberts b-j-roberts merged commit 26081ea into keep-starknet-strange:main Dec 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worlds URLs based on name
2 participants