Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Non-ETH token claim #212

Merged

Conversation

ugur-eren
Copy link
Collaborator

This PR adds support for claims on non-ETH tokens. Estimate fee and claim flow is refactored to support swaps on non-eth tokens.

@ugur-eren ugur-eren requested a review from maciejka July 10, 2024 11:26
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joyboy-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 10:07am

Copy link

vercel bot commented Jul 10, 2024

@ugur-eren is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, beside the fact that Github is raising some code style issues:
image

JoyboyCommunity/src/constants/tokens.ts Outdated Show resolved Hide resolved
@ugur-eren ugur-eren merged commit de5b85a into keep-starknet-strange:main Jul 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants